I have made the changes necessary and backported both of them. So we should be good to go with an RC2
- Houston On Thu, Aug 29, 2024 at 11:14 AM Houston Putman <hous...@apache.org> wrote: > Hey Eric, I was tracking down and fixing this yesterday. There are more > reproducible bugs in the solr operator tests, but I'll make a PR for this > first while I try to confirm the others. > > https://issues.apache.org/jira/browse/SOLR-17427 > > - Houston > > On Thu, Aug 29, 2024 at 6:33 AM David Eric Pugh <de...@yahoo.com.invalid> > wrote: > >> Houston, could you open a JIRA for the API tool, and/or just provide a >> bit more detail on the error? (A bats test would be amazing!) >> >> I suspected we would run into a CLI related issue as we have been >> changing so much there. This one though is new to me! >> >> On Wednesday, August 28, 2024 at 01:25:14 PM EDT, Houston Putman < >> hous...@apache.org> wrote: >> >> -1 (binding) >> >> The smoke tester worked for me (SUCCESS! [1:54:51.828566]) >> >> However, when running the Solr Operator integration tests, I get this: >> >> ERROR: Invalid URI host: null (authority: >> > solr-e2e-2-foo-solrcloud-1.test.solr.org:-1) >> > >> > java.lang.IllegalArgumentException: Invalid URI host: null >> > (authority: solr-e2e-2-foo-solrcloud-1.test.solr.org:-1) >> > at >> org.eclipse.jetty.client.HttpRequest.<init>(HttpRequest.java:102) >> > at >> > org.eclipse.jetty.client.HttpClient.newHttpRequest(HttpClient.java:471) >> > at >> > org.eclipse.jetty.client.HttpClient.newRequest(HttpClient.java:461) >> > at >> > org.eclipse.jetty.client.HttpClient.newRequest(HttpClient.java:450) >> > at >> > >> org.apache.solr.client.solrj.impl.Http2SolrClient.makeRequest(Http2SolrClient.java:664) >> > at >> > >> org.apache.solr.client.solrj.impl.Http2SolrClient.request(Http2SolrClient.java:523) >> > at >> > org.apache.solr.client.solrj.SolrClient.request(SolrClient.java:1194) >> > at org.apache.solr.cli.ApiTool.callGet(ApiTool.java:108) >> > at org.apache.solr.cli.ApiTool.runImpl(ApiTool.java:80) >> > at org.apache.solr.cli.ToolBase.runTool(ToolBase.java:52) >> > at org.apache.solr.cli.SolrCLI.main(SolrCLI.java:227) >> > Response output from Pod Exec: Option 'get''get': Deprecated for >> > removal since 9.7: Use --solr-url instead >> > WARNING: URLs provided to this tool needn't include Solr's >> > context-root (e.g. "/solr"). Such URLs are deprecated and support for >> them >> > will be removed in a future release. Correcting from [ >> > http://solr-e2e-2-foo-solrcloud-1.test.solr.org/solr] to >> > [http://solr-e2e-2-foo-solrcloud-1.test.solr.org:-1]. >> > >> > { >> > Command: "solr api -verbose -get \"http:// >> > >> ${SOLR_HOST}/solr/admin/collections?maxShardsPerNode=10&wt=json&name=e2e-1&replicationFactor=1&numShards=1&async=create-collection-e2e-1-1-1&action=CREATE\"" >> >> } >> >> >> As we can see here, the ApiTool can't handle Solr URLs without ports... I >> think we should reconsider the use of "url.getAuthority()" in its >> entirety, >> I don't know though. >> (To be fair this is an error in the Solr Operator integration tests, there >> should be a port, but it looks like a bad enough error in the CLI) >> >> - Houston >> >> On Wed, Aug 28, 2024 at 5:59 AM Jan Høydahl <jan....@cominvent.com> >> wrote: >> >> > On third attempt smoketester passed: >> > >> > SUCCESS! [0:53:19.266825] >> > >> > +1 (binding) >> > >> > Jan >> > >> > > 27. aug. 2024 kl. 21:09 skrev Anshum Gupta <ans...@apache.org>: >> > > >> > > Please vote for Release Candidate 1 for Apache Solr 9.7.0 >> > > >> > > The artifacts can be downloaded from: >> > > >> > >> https://dist.apache.org/repos/dist/dev/solr/solr-9.7.0-RC1-rev-dd176f1217f0573ea9b9b72c75a3e52e7a49e139 >> > > >> > > You can run the smoke tester directly with this command: >> > > >> > > python3 -u dev-tools/scripts/smokeTestRelease.py \ >> > > >> > >> https://dist.apache.org/repos/dist/dev/solr/solr-9.7.0-RC1-rev-dd176f1217f0573ea9b9b72c75a3e52e7a49e139 >> > > >> > > You can build a release-candidate of the official docker images (full >> & >> > > slim) using the following command: >> > > >> > > SOLR_DOWNLOAD_SERVER= >> > > >> > >> https://dist.apache.org/repos/dist/dev/solr/solr-9.7.0-RC1-rev-dd176f1217f0573ea9b9b72c75a3e52e7a49e139/solr >> > > && \ >> > > docker build >> > $SOLR_DOWNLOAD_SERVER/9.7.0/docker/Dockerfile.official-full \ >> > > --build-arg SOLR_DOWNLOAD_SERVER=$SOLR_DOWNLOAD_SERVER \ >> > > -t solr-rc:9.7.0-1 && \ >> > > docker build >> > $SOLR_DOWNLOAD_SERVER/9.7.0/docker/Dockerfile.official-slim \ >> > > --build-arg SOLR_DOWNLOAD_SERVER=$SOLR_DOWNLOAD_SERVER \ >> > > -t solr-rc:9.7.0-1-slim >> > > >> > > The vote will be open for at least 72 hours i.e. until 2024-08-30 >> 20:00 >> > UTC. >> > > >> > > [ ] +1 approve >> > > [ ] +0 no opinion >> > > [ ] -1 disapprove (and reason why) >> > > >> > > Here is my +1 >> > > >> > > -Anshum Gupta >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org >> > For additional commands, e-mail: dev-h...@solr.apache.org >> > >> > >> > >
