I did run nightlies as well. There were some failures but the console never printed my "nocommit". This is just a quick experiment I'm doing to help me understand some things.
I'm inclined to add comments to say that calling getRealtimeSearcher will "nearly always" return an existing one without having to open one. This is useful for anyone reading this code. Ideally the comment should describe why there might not be one. If it's so extremely rare... I'd argue the complexity of making the distinction is not worth it. A straw-man proposal, anyway :-) On Tue, Jul 16, 2024 at 9:27 AM Mark Miller <markrmil...@gmail.com> wrote: > > I'm not currently looking at any code, but if the idea is that you put in > that assert and ran the nightly or none nightly tests, I wouldn't come to > the conclusion that that code path is never hit unless you've walked > through all of the possible concurrency potential around it in the code. > > - MRM > > > On Tue, Jul 16, 2024 at 8:04 AM David Smiley <dsmi...@apache.org> wrote: > > > SolrCore.getRealtimeSearcher returns the existing searcher if there is > > one, or otherwise creates one. I did a little experiment to "assert > > false" where it creates one. It never tripped! On any commit, that > > searcher is installed as the realtime searcher, and furthermore a > > searcher is created on core open as well (of course). I wonder what > > led to the distinction in the first place. Has it always been this > > way or was there a time long ago when there was a real chance of not > > having a "real" searcher? Hmm. > > > > ~ David Smiley > > Apache Lucene/Solr Search Developer > > http://www.linkedin.com/in/davidwsmiley > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > For additional commands, e-mail: dev-h...@solr.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
