Hi all…. Quick update that I merged SOLR-16842 into main. I wanted to confirm that our Jenkins builds are still happy, and while our normal Jenkins boxes are busted, I see that we have “Solr-Check-main-s390x”? Looking at it, it appears that recent code merges are fine, that the one test that failed on run https://ci-builds.apache.org/job/Solr/job/Solr-Check-main-s390x/646/ is probably just flaky. So feeling good about that!
https://ci-builds.apache.org/job/Solr/job/Solr-Check-main-s390x/ I have started a back port PR to branch_9x, however it’s not going well…. :-(. https://github.com/apache/solr/pull/2540. There are more differences between main and branch_9x for the CLI than I quite realized. Bats tests on main that aren’t on branch_9x, all the changes in how we craft Solr urls, the fact that we never back ported basic auth for SolrCLI tools…. We replaced “CreateCoreTool" and “CreateCollectionTool" tools with “CreateTool” on main... I haven’t committed all my local changes as the tests are failing, but may try that…. I’m running out of time before vacation for three weeks (hello Spain!) and so thinking: 1) Ask for help. If someone else wanted to take a crack at the back port who has more Git-fu than I do, more than welcome. 2) Push up the code to the branch even though tests etc fail. 3) Not worry about back port to branch_9x till I get back last week of July. 4) Pivot on the back port plan and declare SOLR-16842 to be a Solr 10 only feature. Figure out a new plan for removing deprecated options from code. (That is starting to feel the path of least resistance to me). I would very much like to NOT rollback the change so didn’t list that as an option…. Thanks Eric > On Jun 22, 2024, at 10:05 AM, Eric Pugh <ep...@opensourceconnections.com> > wrote: > > Thanks Jason, I’m happy to stall till end of day on Monday to click “merge”! > Thanks. > > >> On Jun 21, 2024, at 12:33 PM, Jason Gerlowski <gerlowsk...@gmail.com> wrote: >> >> Hey Eric, >> >> Sorry for the delay - I am hoping to review that PR. I'll try to have >> a review done by Monday (if not today). That should leave a week or >> so for any followups prior to your big trip! (Safe travels!) >> >> If Monday isn't early enough and you need to merge on Saturday, IMO >> that's fine. The PR's been open for nearly a year and you've been >> more than patient at this point. In that case I'll just review >> post-merge and we can handle any follow ups as needed. >> >> Best, >> >> Jason >> >> On Fri, Jun 21, 2024 at 12:07 PM Eric Pugh >> <ep...@opensourceconnections.com> wrote: >>> >>> Hi all, I’m planning on merging https://github.com/apache/solr/pull/1768, >>> SOLR-16824: Adopt Linux Command line tool pattern of -- for long option >>> commands tomorrow (Saturday). >>> >>> I’m going to be traveling (Spain!) for three weeks starting June 29th, and >>> I’d like to make sure this fairly big change has plenty time for any >>> panicky follow up fixes that turn out to be needed when it goes into main >>> and branch_9x. >>> >>> Eric >>> >>> >>> _______________________ >>> Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | >>> http://www.opensourceconnections.com >>> <http://www.opensourceconnections.com/> | My Free/Busy >>> <http://tinyurl.com/eric-cal> >>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed >>> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> >>> This e-mail and all contents, including attachments, is considered to be >>> Company Confidential unless explicitly stated otherwise, regardless of >>> whether attachments are marked as such. >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org >> For additional commands, e-mail: dev-h...@solr.apache.org >> > > _______________________ > Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com <http://www.opensourceconnections.com/> > | My Free/Busy <http://tinyurl.com/eric-cal> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed > <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> > > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > _______________________ Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
