I appreciate the encouragement Houston, I was starting to flag a bit on this…
One thing I noticed is that some of our tools, like the ZK related ones, use the shell code to do arg parsing, and then we pass them into Java. Those will still work with old and new parameters, but until we move the logic into Java, you won’t get the deprecation messages. For example “bin/solr zk ls /blah/blah” doesn’t care that the path parameter went from “-path” to “—path” in the Java code ;-). Honestly, for those, I’m not sure how we remove the special arg parsing and just rely on commons-cli, and so is out of scope of this PR. > On Jun 12, 2024, at 10:25 AM, Houston Putman <hous...@apache.org> wrote: > > Thanks for doing the hard work eric! > > I think that's fine for the ref guide. > > - Houston > > On Wed, Jun 12, 2024 at 7:19 AM Eric Pugh <ep...@opensourceconnections.com > <mailto:ep...@opensourceconnections.com>> > wrote: > >> I talked to Jason G a bit yesterday about “do we need to support all the >> renamed options as deprecations” and his thought was yes.. that scripts >> etc that use bin/solr shouldn’t break from 9.6 to 9.7… >> >> Sigh. >> >> So, I’m going to add in all the old deprecated options. For example, on >> the “upconfig” command we have a “-confdir” parameter in 9.6, and in 9.7 it >> will be “—confider”, but the old one will still work. You do get a warning >> that the command is deprecated which is nice. >> >> Then, in main I will remove all the old deprecated options, so we’ll slim >> down the code base… >> >> For the Solr Ref Guide, I plan on just updating it to the non deprecated >> commands and back porting it to 9.x branch of the docs…. >> >> Thoughts? >> >> Eric >> >> _______________________ >> Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | >> http://www.opensourceconnections.com < >> http://www.opensourceconnections.com/> | My Free/Busy < >> http://tinyurl.com/eric-cal> >> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < >> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> >> >> This e-mail and all contents, including attachments, is considered to be >> Company Confidential unless explicitly stated otherwise, regardless of >> whether attachments are marked as such. _______________________ Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
