I would be surprised if my refactor caused a change in this behavior. All I did was move some initialization out into a ServeletContextListener. If I did cause such a change, that would be unintended.
>From the perspective of a web application container (which is what Jetty is). There's no reason to shut down if any one application fails to deploy... J2EE containers are meant to host multiple applications smoothly and there are plenty of use cases where the container is empty and then apps are deployed into it, or existing apps are undeployed and then new ones are deployed, possibly passing through a zero active apps state. Thus it probably takes special measures to cause a shutdown of the whole container due to the failure of a single web app deployed into it (solr). -Gus On Tue, Apr 30, 2024 at 3:15 PM David Smiley <dsmi...@apache.org> wrote: > > I noticed (as well as my colleague Vincent and with more detail and > root causing) that if Solr's CoreContainer has some issue starting up > for almost any reason, that it only logs an error (in > SolrDispatchFilter). From Jetty’s perspective, startup has succeeded, > thus the server is running. Seeing this in a test, it can seem to > hang. Jetty is running but Solr rejects all requests. Shouldn’t it > propagate the exception and fail startup? > > https://github.com/apache/solr/blob/242e6c861b8fdf4ac75ed9e1b083f3c2f18f6c40/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java#L163 > > I could be wrong but I thought this behavior happened newly since a > big refactor in SolrDispatchFilter by Gus a couple years ago. Yet the > pertinent lines of code go way back to Mark in 2014 so who knows. > > ~ David Smiley > Apache Lucene/Solr Search Developer > http://www.linkedin.com/in/davidwsmiley > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > For additional commands, e-mail: dev-h...@solr.apache.org > -- http://www.needhamsoftware.com (work) https://a.co/d/b2sZLD9 (my fantasy fiction book) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
