https://issues.apache.org/jira/browse/SOLR-17207
: Date: Tue, 19 Mar 2024 10:31:54 +0100 : From: Uwe Schindler <u...@thetaphi.de> : To: Chris Hostetter <hossman_luc...@fucit.org>, dev@solr.apache.org : Subject: Re: LocaleTest fails only on thetaphi CI : : Hi, : : in Lucene we have similar (production code) which disables the vector API when : the default locale has Turkish "i" problems on certain JVMs: : : https://github.com/apache/lucene/blob/04dd8d32afcdc4f0798647f173db2924a3d38b42/lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java#L192-L199 : (it's no longer in main branch as it is Java 21) : : So instead of blacklisting specific locales it is better to just check if : current locale fails a basic test (like the toUpperCase in above check). If it : fails you know its broken. : : In addition, should we also print a warning on startup of Solr if such a : locale is used and Kerberos is used? : : Uwe : : Am 18.03.2024 um 20:05 schrieb Chris Hostetter: : > This doesn't appear to be much of a "test" ... it instead appears to have : > been written as a tool for people to run to find out if the current JVM : > supports *any* locales (regardless of which one is used to run the test) : > that don't work with MiniKdc -- and to report (by failing) any that it : > finds which aren't already tracked in : > KerberosTestServices.incompatibleLanguagesWithMiniKdc. : > : > ie: Run this anytime a new JVM comes out to decide if new need to update : > KerberosTestServices.incompatibleLanguagesWithMiniKdc : > : > (It seems to be failing on Uwe's jenkins because he's testing w/newer JVMs : > that have more Locales MiniKdc doesn't like that aren't tracked in : > incompatibleLanguagesWithMiniKdc) : > : > : > The entire design of : > this "test" and KerberosTestServices.incompatibleLanguagesWithMiniKdc : > seems flawed ? : > : > A much saner way to do this would be to refactor the guts of : > LocaleTest.testWithKdc into a new "public static final void : > assumeMiniKdcSupported()" in KerberosTestServices that throws : > AssumptionViolatedException if the default locale doesn't work with : > MiniKdc. Any code that currently checks : > KerberosTestServices.incompatibleLanguagesWithMiniKdc should instead call : > that method new method. : > : > (this is on par with other test environment sanity checks like : > assumeWorkingMockito() and HadoopTestUtil.checkAssumptions() work) : > : > : > : > : Date: Thu, 14 Mar 2024 21:09:17 -0400 : > : From: David Smiley <dsmi...@apache.org> : > : Reply-To: dev@solr.apache.org : > : To: Uwe Schindler <u...@thetaphi.de>, bui...@solr.apache.org : > : Subject: LocaleTest fails only on thetaphi CI : > : : > : Hi Uwe, : > : : > : This test: : > : org.apache.solr.security.hadoop.LocaleTest.testwithKdc : > : fails extremely often specifically on your thetaphi_solr CI, as seen here: : > : http://fucit.org/solr-jenkins-reports/failure-report.html : > : : > : ~ David Smiley : > : Apache Lucene/Solr Search Developer : > : http://www.linkedin.com/in/davidwsmiley : > : : > : --------------------------------------------------------------------- : > : To unsubscribe, e-mail: builds-unsubscr...@solr.apache.org : > : For additional commands, e-mail: builds-h...@solr.apache.org : > : : > : : > : > -Hoss : > http://www.lucidworks.com/ : : -- : Uwe Schindler : Achterdiek 19, D-28357 Bremen : https://www.thetaphi.de : eMail: u...@thetaphi.de : : -Hoss http://www.lucidworks.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
