Hi all, 

I am poking around ZkCLI.java, and noticed that the compression for a 
“state.json” file logic is in this file.   I’m realizing that the existing 
bin/solr zk cp command knows nothing about a “state.json” file being compressed 
or not, and so if you do 

        bin/solr zk cp my_local_state.json zk:/state.json -z localhost:9983

Then I think you don’t get the compression aspect kicking in. 

I could copy that logic into the ZkCpTool.java, but wondering if there is a 
better refactoring?   Could this logic live in either SolrZkClient.java or 
ZkMaintenanceUtils.java ?   

Thoughts?

Eric
_______________________
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | 
http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | 
My Free/Busy <http://tinyurl.com/eric-cal>  
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 
<https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
    
This e-mail and all contents, including attachments, is considered to be 
Company Confidential unless explicitly stated otherwise, regardless of whether 
attachments are marked as such.

Reply via email to