The legacy code that we have has tests that sets the router field and that uses the legacy getIdField method to retrieve this later. So hardcoding "id" is not enough for my use case.
I have what seems like a working solution though. I get the router field from the doc collection. This code works with our existing tests. If anyone can spot any shortcomings with it, I would appreciate the feedback. https://github.com/apache/incubator-pekko-connectors/pull/481/files#diff-d5dad3ac825b558eafae6d5862c5ccb1848f4789165c5b7f1a4f865e0ecdc0f4 On 2024/02/12 23:30:35 Gus Heck wrote: > Should our build check for @deprecated without following text describing > the path forward? > > On Mon, Feb 12, 2024 at 6:26 PM PJ Fanning <fannin...@apache.org> wrote: > > > Thanks David. That seems like the best approach. > > > > On 2024/02/12 23:21:26 David Smiley wrote: > > > Just presume the uniqueKeyField to be "id", especially in SolrCloud. > > > If one of your users uses something different, I'd be surprised! > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > > For additional commands, e-mail: dev-h...@solr.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > For additional commands, e-mail: dev-h...@solr.apache.org > > > > > > -- > http://www.needhamsoftware.com (work) > https://a.co/d/b2sZLD9 (my fantasy fiction book) > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
