Hi, I fixed the issue (which was really hard), because I missed that there's also a .gitattributes file in solr subfolder (relic from LuSolr times). We should really move the patterns up.
Problem with the gitattributes file is that it sets all files to "autodetection" of line endings, but on the other hand does enforce spotless to use LF (UNIX). Lucene does not do this. IMHO, we should remove the autodetection of text files and enforce "LF/UNIX". Alternatively we must change the configuration of spotless to detect git's settings (can be done!). I opened a bug report: https://issues.apache.org/jira/browse/SOLR-15521 The build now passes after I enforced all "*.java" files to have Unix line ending normalization in Git, but then Windows fails again for another reason: sassc cannot be installed on widnows, as you can't run makefiles or compile stuff by default. This makes gradlew precommit completely fail for mw. We should really fix this and remove sassc! Bug is here (blocker): Bug report: https://issues.apache.org/jira/browse/SOLR-15520 Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -----Original Message----- > From: Uwe Schindler <u...@thetaphi.de> > Sent: Tuesday, July 6, 2021 1:14 PM > To: dev@solr.apache.org > Subject: RE: [JENKINS-EA] Solr-main-Windows (64bit/jdk-18-ea+4) - Build # 224 > - Still Failing! > > Hi, > > i cleaned the git repository on Jenkins, but the error does not go away. I > also > execute spotless on my local machine, it also modifies the 3 files, but when > trying to commit it says there are no changes, only line endings. > > To me the issue looks like in the GIT repo the file natively has windows line > endings. If you change those, git refuses to commit. Does anybody have an idea > how to fix this? How can I commit the binary blob to git ignoring that it has > line > ending changes only? > > Uwe > > ----- > Uwe Schindler > Achterdiek 19, D-28357 Bremen > https://www.thetaphi.de > eMail: u...@thetaphi.de > > > -----Original Message----- > > From: Uwe Schindler <u...@thetaphi.de> > > Sent: Tuesday, July 6, 2021 9:56 AM > > To: dev@solr.apache.org > > Subject: RE: [JENKINS-EA] Solr-main-Windows (64bit/jdk-18-ea+4) - Build # > 224 > > - Still Failing! > > > > Hi, > > > > all Windows builds fail currently for Solr, because Spotless complains: > > > > 1: Task failed with an exception. > > ----------- > > * What went wrong: > > Execution failed for task ':solr:contrib:jaegertracer- > > configurator:spotlessJavaCheck'. > > > The following files had format violations: > > solr\contrib\jaegertracer- > > configurator\src\java\org\apache\solr\jaeger\JaegerTracerConfigurator.java > > @@ -1,31 +1,31 @@ > > -/*\r\n > > - * Licensed to the Apache Software Foundation (ASF) under one or > > more\r\n > > - * contributor license agreements. See the NOTICE file > > distributed > > with\r\n > > - * this work for additional information regarding copyright > > ownership.\r\n > > - * The ASF licenses this file to You under the Apache License, > > Version > > 2.0\r\n > > - * (the "License"); you may not use this file except in > > compliance > > with\r\n > > - * the License. You may obtain a copy of the License at\r\n > > - *\r\n > > - * http://www.apache.org/licenses/LICENSE-2.0\r\n > > - *\r\n > > - * Unless required by applicable law or agreed to in writing, > software\r\n > > - * distributed under the License is distributed on an "AS IS" > > BASIS,\r\n > > - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either > express > > or implied.\r\n > > - * See the License for the specific language governing > > permissions > > and\r\n > > - * limitations under the License.\r\n > > - */\r\n > > -\r\n > > -package org.apache.solr.jaeger;\r\n > > -\r\n > > -import io.jaegertracing.Configuration;\r\n > > -import io.opentracing.Tracer;\r\n > > -import org.apache.solr.core.TracerConfigurator;\r\n > > -\r\n > > -public class JaegerTracerConfigurator extends TracerConfigurator > > {\r\n > > -\r\n > > - @Override\r\n > > - public Tracer getTracer() {\r\n > > - // See javadocs on Configuration for how to configure via > > sys props > or > > env vars\r\n > > - return Configuration.fromEnv("solr").getTracer();\r\n > > - }\r\n > > -}\r\n > > +/*\n > > + * Licensed to the Apache Software Foundation (ASF) under one or > > more\n > > + * contributor license agreements. See the NOTICE file > > distributed > > with\n > > + * this work for additional information regarding copyright > ownership.\n > > + * The ASF licenses this file to You under the Apache License, > > Version > > 2.0\n > > + * (the "License"); you may not use this file except in > > compliance > with\n > > + * the License. You may obtain a copy of the License at\n > > + *\n > > + * http://www.apache.org/licenses/LICENSE-2.0\n > > + *\n > > + * Unless required by applicable law or agreed to in writing, > software\n > > + * distributed under the License is distributed on an "AS IS" > > BASIS,\n > > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either > express > > or implied.\n > > + * See the License for the specific language governing > > permissions > and\n > > + * limitations under the License.\n > > + */\n > > +\n > > ... (14 more lines that didn't fit) > > Violations also present in: > > solr\contrib\jaegertracer- > > configurator\src\java\org\apache\solr\jaeger\package-info.java > > solr\contrib\jaegertracer- > > configurator\src\test\org\apache\solr\jaeger\TestJaegerConfigurator.java > > Run 'gradlew.bat :solr:contrib:jaegertracer-configurator:spotlessApply' > > to fix > > these violations. > > > > It looks like the line endings as commited to git are wrong. > > > > Uwe > > > > ----- > > Uwe Schindler > > Achterdiek 19, D-28357 Bremen > > https://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > > -----Original Message----- > > > From: Policeman Jenkins Server <jenk...@thetaphi.de> > > > Sent: Tuesday, July 6, 2021 4:01 AM > > > To: bui...@solr.apache.org > > > Subject: [JENKINS-EA] Solr-main-Windows (64bit/jdk-18-ea+4) - Build # 224 > - > > > Still Failing! > > > Importance: Low > > > > > > Build: https://jenkins.thetaphi.de/job/Solr-main-Windows/224/ > > > Java: 64bit/jdk-18-ea+4 -XX:-UseCompressedOops -XX:+UseZGC > > > > > > 1 tests failed. > > > FAILED: org.apache.solr.util.TestCircuitBreaker.testResponseWithCBTiming > > > > > > Error Message: > > > java.lang.RuntimeException: Exception during query > > > > > > Stack Trace: > > > java.lang.RuntimeException: Exception during query > > > at > > > > > > __randomizedtesting.SeedInfo.seed([938060271D266556:7B5CCDC5EECE7F76] > > > :0) > > > at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:1050) > > > at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:1012) > > > at > > > > > > org.apache.solr.util.TestCircuitBreaker.testResponseWithCBTiming(TestCircuitB > > > reaker.java:247) > > > at > > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > > > Method) > > > at > > > > > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethod > > > AccessorImpl.java:77) > > > at > > > > > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Delegating > > > MethodAccessorImpl.java:43) > > > at java.base/java.lang.reflect.Method.invoke(Method.java:568) > > > at > > > > > > com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRu > > > nner.java:1754) > > > at > > > > > > com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(Randomiz > > > edRunner.java:942) > > > at > > > > > > com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(Randomiz > > > edRunner.java:978) > > > at > > > > > > com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(Randomi > > > zedRunner.java:992) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.eval > > > uate(SystemPropertiesRestoreRule.java:57) > > > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > > > at > > > > > > org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSet > > > upTeardownChained.java:44) > > > at > > > > > > org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfter > > > Rule.java:43) > > > at > > > > > > org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThrea > > > dAndTestName.java:45) > > > at > > > > > > org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgn > > > oreAfterMaxFailures.java:60) > > > at > > > > > > org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.ja > > > va:44) > > > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stateme > > > ntAdapter.java:36) > > > at > > > > > > com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run( > > > ThreadLeakControl.java:370) > > > at > > > > > > com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(Th > > > readLeakControl.java:819) > > > at > > > > > > com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLea > > > kControl.java:470) > > > at > > > > com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(Rando > > > mizedRunner.java:951) > > > at > > > > > > com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(Randomiz > > > edRunner.java:836) > > > at > > > > > > com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(Randomiz > > > edRunner.java:887) > > > at > > > > > > com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(Randomiz > > > edRunner.java:898) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stateme > > > ntAdapter.java:36) > > > at > > > > > > org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfter > > > Rule.java:43) > > > at > > > > > > org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfter > > > Rule.java:43) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.eval > > > uate(SystemPropertiesRestoreRule.java:57) > > > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > > > at > > > > > > org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfter > > > Rule.java:43) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stateme > > > ntAdapter.java:36) > > > at > > > > > > org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClass > > > Name.java:38) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethod > > > sRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethod > > > sRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stateme > > > ntAdapter.java:36) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stateme > > > ntAdapter.java:36) > > > at > > > > > > org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertio > > > nsRequired.java:53) > > > at > > > > > > org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfter > > > Rule.java:43) > > > at > > > > > > org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.ja > > > va:44) > > > at > > > > > > org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgn > > > oreAfterMaxFailures.java:60) > > > at > > > > > > org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTest > > > Suites.java:47) > > > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > > > at > > > > > > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stateme > > > ntAdapter.java:36) > > > at > > > > > > com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run( > > > ThreadLeakControl.java:370) > > > at > > > > > > com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutin > > > gTask$0(ThreadLeakControl.java:826) > > > at java.base/java.lang.Thread.run(Thread.java:833) > > > Caused by: org.apache.solr.common.SolrException: Circuit Breakers tripped > > > Memory Circuit Breaker triggered as JVM heap usage values are greater > than > > > allocated threshold.Seen JVM heap memory usage 429916160 and > allocated > > > threshold 402653184 > > > > > > at > > > > > > org.apache.solr.handler.component.SearchHandler.handleRequestBody(Search > > > Handler.java:321) > > > at > > > > > > org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBa > > > se.java:212) > > > at org.apache.solr.core.SolrCore.execute(SolrCore.java:2608) > > > at org.apache.solr.util.TestHarness.query(TestHarness.java:342) > > > at org.apache.solr.util.TestHarness.query(TestHarness.java:324) > > > at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:1026) > > > ... 48 more > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > For additional commands, e-mail: dev-h...@solr.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > For additional commands, e-mail: dev-h...@solr.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
