raducotescu commented on code in PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#discussion_r1338185241
##########
pom.xml:
##########
@@ -249,7 +249,7 @@
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.testing.paxexam</artifactId>
- <version>3.1.0</version>
+ <version>4.0.0</version>
Review Comment:
This update brought `org.apache.felix.jetty-5.0.0`, which uses Jetty 11.
Unfortunately, there's a Servlet Request Wrapper in Felix that doesn't
correctly return the set attributes if they were `RequestDispatcher` attributes
- see
https://github.com/apache/felix-dev/blob/d691a59c9e78749fad20a10a002c969e4e583800/http/wrappers/src/main/java/org/apache/felix/http/javaxwrappers/ServletRequestWrapper.java#L108-L182
@cziegeler will fix this in Felix and for this test setup we could override
the Jetty version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
