[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694235#comment-17694235
]
Andreas Schaefer commented on SLING-10900:
------------------------------------------
After testing with AEM this is the current state:
# graphql-java 20.0 leads to class loading issues with GenericConnection
(pagination) which is not only a Sling issue
# graphql-java 17.4, 18.3, 19.3 and 20.0 all contained an import of sun.misc
and the MANIFEST.MF is not the first entry
## Both of these issues are fixed and accepted on 20.x
## There is a pending PR for 19.x with the back port of these fixes
([https://github.com/graphql-java/graphql-java/pull/3099])
# graphql-java 19.3 works just fine with Sling Graphql Core but not when used
in a Feature Model environment
As the issue with class loading seems to be bigger issue so as of now 19.3
seems to be the best target to upgrade to.
I created a PR:
[https://github.com/apache/sling-org-apache-sling-graphql-core/pull/34] that
contains the fixes for the upgrade as well as the adjustments to the tests.
That anyone who wants to use this version inside any Feature Model systems need
to use the fixed version which can be found in here:
[https://github.com/schaefa/graphql-java/tree/issue/manifest-mf.order.19x]. Use
the mentioned above process on created the Graphql-java bundle but with
RELEASE_VERISON of 19.4 or 19.4-SNAPSHOT and then use that then.
> Update graphl-java to version 17
> --------------------------------
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
> Reporter: Radu Cotescu
> Assignee: Andreas Schaefer
> Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
