I did locally also following change and I'm able to reproduce issue in
debug mode, but I'm not sure if it's sufficient to assume it's correct.
1) I have removed code which creates [1] IListPresentationModel bead
2) I have added in _datagrid.sass in j|DataGridColumnList line:
IListPresentationModel:
ClassReference("org.apache.royale.jewel.beads.models.DataGridColumnListPresentationModel")
In the results I should in my column beads arrach my
IListPresentationModel, but I don't have it at all...
[1]
https://github.com/apache/royale-asjs/blob/0a33c44db45c684ad2fc742e13e7222b14050f61/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/DataGridColumnList.as#L109
śr., 2 wrz 2020 o 10:48 Piotr Zarzycki <[email protected]>
napisał(a):
> Carlos,
>
> I looked into columnList and one of the column. I have found that it
> contains in beads array 2 instances of
> DataGridColumnListItemRendererInitializer [1]
>
> [1]
> https://github.com/apache/royale-asjs/blob/7b41eaee89264b54839564aa8354bb9836aa0dea/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DataGridView.as#L287
> [2] https://ibb.co/RSXvt07
>
> Thanks,
> Piotr
>
> śr., 2 wrz 2020 o 10:23 Piotr Zarzycki <[email protected]>
> napisał(a):
>
>> Never mind I think I figured it out.
>>
>> śr., 2 wrz 2020 o 10:13 Piotr Zarzycki <[email protected]>
>> napisał(a):
>>
>>> Carlos,
>>>
>>> Unfortunately I cannot extract what code causing that issue. Carlos how
>>> can I change default.css in framework ? I mean if I change it after build
>>> my changes are wiped out - this is related to SASS ?
>>>
>>> I think this is issue in DataGridView - we are calling createLists function
>>> to early and presentation model list is not yet initialized at that moment.
>>>
>>> Thanks,
>>> Piotr
>>>
>>> Thanks,
>>> Piotr
>>>
>>> wt., 1 wrz 2020 o 18:35 Carlos Rovira <[email protected]>
>>> napisał(a):
>>>
>>>> Hi Piotr,
>>>>
>>>> ok, I use to try with all examples I have available so if the code is
>>>> something custom you have, I need that you provide some example with a
>>>> minimal code to showcase the problem so I can know what the problem is.
>>>>
>>>> For now I'll let you know the issue so you can see how to refactor your
>>>> code and see if you can fix yourself:
>>>> 1.- maybe you're using some Presentation Model (PM) directly at an early
>>>> time in a custom code. See that I need to reference the PM after the
>>>> column
>>>> list is added, since it doesn't exists until "initComplete"
>>>> 2.- See if you have it as ListPresentationModel, now that List needs to
>>>> have DataGridColumnListPresentationModel instead of the other.
>>>>
>>>> The big problem that was hidden is that I was using list PM in the
>>>> constructor, and that made it impossible to add a custom PM that of
>>>> course
>>>> made the PM itself useless.
>>>>
>>>> Let me know if you find the issue, or if not try to make a simple
>>>> project
>>>> so I can take a look at it and reproduce the issue
>>>>
>>>> thanks
>>>>
>>>>
>>>> El mar., 1 sept. 2020 a las 17:59, Piotr Zarzycki (<
>>>> [email protected]>) escribió:
>>>>
>>>> > I forgot to mention that it is not reproducible in tourdejewel. There
>>>> is
>>>> > probably some case which you don't have in example code. I thought
>>>> you will
>>>> > know maybe based on what you did why it happened. Maybe something is
>>>> being
>>>> > called to early...
>>>> >
>>>> > wt., 1 wrz 2020 o 16:58 Carlos Rovira <[email protected]>
>>>> > napisał(a):
>>>> >
>>>> > > Hi Piotr,
>>>> > >
>>>> > > maybe something is stale in your build? I just tried the release
>>>> version
>>>> > > and all seems to work fine.
>>>> > > Let me know what could be
>>>> > > Thanks
>>>> > >
>>>> > > El mar., 1 sept. 2020 a las 16:56, Carlos Rovira (<
>>>> > [email protected]
>>>> > > >)
>>>> > > escribió:
>>>> > >
>>>> > > > Thanks for reporting Piotr,
>>>> > > > I will take a look. It's part of the fixes yesterday about PMs.
>>>> > > >
>>>> > > >
>>>> > > > El mar., 1 sept. 2020 a las 16:25, Piotr Zarzycki (<
>>>> > > > [email protected]>) escribió:
>>>> > > >
>>>> > > >> Hi,
>>>> > > >>
>>>> > > >> I have pulled all changes from Royale and build our app. Debug
>>>> build
>>>> > is
>>>> > > >> working perfectly fine, but release build is failing. I cannot
>>>> find
>>>> > > cause
>>>> > > >> of issue, but here is the details.
>>>> > > >>
>>>> > > >> I'm getting NPE in this line [1] - It looks like
>>>> > > >> DataGridColumnListPresentationModel is null.
>>>> > > >>
>>>> > > >> TypeError: Cannot set property 'rowHeight' of null
>>>> > > >>
>>>> > > >> Any ideas ?
>>>> > > >>
>>>> > > >> [1]
>>>> > > >>
>>>> > > >>
>>>> > >
>>>> >
>>>> https://github.com/apache/royale-asjs/blob/94693e9583680ffa992ead9fc4663bb9e25b97aa/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DataGridView.as#L237
>>>> > > >>
>>>> > > >> Thanks,
>>>> > > >> --
>>>> > > >>
>>>> > > >> Piotr Zarzycki
>>>> > > >>
>>>> > > >
>>>> > > >
>>>> > > > --
>>>> > > > Carlos Rovira
>>>> > > > http://about.me/carlosrovira
>>>> > > >
>>>> > > >
>>>> > >
>>>> > > --
>>>> > > Carlos Rovira
>>>> > > http://about.me/carlosrovira
>>>> > >
>>>> >
>>>> >
>>>> > --
>>>> >
>>>> > Piotr Zarzycki
>>>> >
>>>>
>>>>
>>>> --
>>>> Carlos Rovira
>>>> http://about.me/carlosrovira
>>>>
>>>
>>>
>>> --
>>>
>>> Piotr Zarzycki
>>>
>>
>>
>> --
>>
>> Piotr Zarzycki
>>
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
