We have no power until maybe Tuesday due to hurricane Dorian passing by. Can review the files then.
On Sun, Sep 8, 2019, 4:47 AM Alex Harui, <[email protected]> wrote: > I ran the ApproveRoyale script. It is a good idea for the RM to run it > before sending out the vote emails. The script found: > > Generated output is in the binary package in these folders and shouldn't > be, IMO. Some clean step is missing somewhere. > BasicJS/src/test > CoreJS/src/test > NetworkJS/src/test > ReflectionJS/src/test > RoyaleUnitJS/src/test > XMLJS/src/test > > This file was found by rat. I don't think it should be in the packages or > our repo. > .factorypath > > I pushed to the release branch some changes to the README URLs for > playerglobal > The README still says to use sudo on Mac for NPM. I didn't have time to > confirm. Om, if you really think it shouldn't be in there go remove it. > > I also pushed changes to the NOTICE file copyright years > > The build failed because at least this one folder is missing from the > package. The packaging scripts may need to be changed to pick up new > folders. > royale-compiler/royaleunit-ant-tasks > > And then there is the RELEASE_NOTES files. Andrew can you edit both the > top-level RELEASE_NOTES.md and releasemgr/RELEASE_NOTES in royale-asjs? > > There might be more if I get past the royaleunit-ant-tasks failure, but > I'm out of time for another 15 hours or so. > > HTH, > -Alex > > On 9/6/19, 9:54 AM, "Andrew Wetmore" <[email protected]> wrote: > > I have only looked at the top-level release notes and readme files. > Should > I wait a day or so before digging down to look at the similar files in > folders? > > On Fri, Sep 6, 2019 at 1:45 PM Josh Tynjala <[email protected] > > > wrote: > > > I just updated the royale-compiler and royale-asjs release notes > with the > > things that I worked on. They're in the develop branch for now. > > > > -- > > Josh Tynjala > > Bowler Hat LLC < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7Ccd5c799cbcb94f13f2d508d732eae327%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637033856755836697&sdata=vm%2BN2O4dit0i7WNu0Wf29K%2BjqMPRoP4pcNkfdph6GWc%3D&reserved=0 > > > > > > > > On Fri, Sep 6, 2019 at 9:37 AM Piotr Zarzycki < > [email protected]> > > wrote: > > > > > I was thinking about that in a very brave way at the beginning ! I > was > > > going to go trough commits from our last 0.9.4 release and prepare > nice > > > list for CHANGELOG, but since everything took double time then I > assume. > > - > > > It's not going to happen from my sight. > > > > > > On Fri, Sep 6, 2019, 5:13 PM Andrew Wetmore <[email protected]> > wrote: > > > > > > > The release notes file doesn't seem to have a section about > what's in > > > > 0.9.6, the current release. > > > > > > > > a > > > > > > > > On Fri, Sep 6, 2019 at 11:29 AM Piotr Zarzycki < > > > [email protected]> > > > > wrote: > > > > > > > > > Hi Carlos, > > > > > > > > > > IT depends on what commit MX is failing. I did branch for this > RC > > > couple > > > > of > > > > > days ago. In that time I was seeing some commits to develop > related > > to > > > > MX. > > > > > > > > > > Thanks, > > > > > Piotr > > > > > > > > > > On Fri, Sep 6, 2019, 4:02 PM Carlos Rovira < > [email protected]> > > > > > wrote: > > > > > > > > > > > Hi Piotr, > > > > > > > > > > > > thanks. One question I have is: I think MX Test was failing, > does > > it > > > > > > affects the release or are not crucial to get the bits out? > > > > > > > > > > > > Thanks > > > > > > > > > > > > El vie., 6 sept. 2019 a las 13:10, Piotr Zarzycki (< > > > > > > [email protected]>) escribió: > > > > > > > > > > > > > Hi Guys, > > > > > > > > > > > > > > I have upload manually ant artifacts. Please start > reviewing > > stuff. > > > > > What > > > > > > if > > > > > > > vote passes - Should we merge 0.9.6 tag to develop ? > > > > > > > > > > > > > > Thanks, > > > > > > > Piotr > > > > > > > > > > > > > > pt., 6 wrz 2019 o 13:09 Apache Royale CI Server < > > > > > > [email protected]> > > > > > > > napisał(a): > > > > > > > > > > > > > > > This is the discussion thread. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Piotr Zarzycki > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > Piotr Zarzycki > > > > > > > > > > > > > > Patreon: * > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ccd5c799cbcb94f13f2d508d732eae327%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637033856755836697&sdata=moeir%2BOsYnCZDPkHAFbTPRhydzDnBILXP%2FZhsfVcTdc%3D&reserved=0 > > > > > > > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ccd5c799cbcb94f13f2d508d732eae327%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637033856755836697&sdata=moeir%2BOsYnCZDPkHAFbTPRhydzDnBILXP%2FZhsfVcTdc%3D&reserved=0 > >* > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Carlos Rovira > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ccd5c799cbcb94f13f2d508d732eae327%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637033856755836697&sdata=HW2N%2FKqnt%2BRo%2FuR9SIpT%2BI5me%2Bayg%2FJzApfbI37UVCc%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Andrew Wetmore > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcottage14.blogspot.com%2F&data=02%7C01%7Caharui%40adobe.com%7Ccd5c799cbcb94f13f2d508d732eae327%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637033856755836697&sdata=KV4vXyCGGHAkJrKTLjDdS%2FI5V%2BgQ9KKl20NuYfqsu3M%3D&reserved=0 > > > > > > > > > > > > -- > Andrew Wetmore > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcottage14.blogspot.com%2F&data=02%7C01%7Caharui%40adobe.com%7Ccd5c799cbcb94f13f2d508d732eae327%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637033856755836697&sdata=KV4vXyCGGHAkJrKTLjDdS%2FI5V%2BgQ9KKl20NuYfqsu3M%3D&reserved=0 > > >
