It was a step in that direction. I did not test it in VSCode to see if it had become a valid SDK for code intelligence again. I don't know for sure what other changes are necessary to make that happen.
- Josh On Mon, Jul 22, 2019, 6:39 AM Carlos Rovira <[email protected]> wrote: > Hi Piotr, > > I'm asking for this specific commit from Josh: "fixes for config files in > Maven distribution" : 85333c6f6d0a98e1b0a1ff984e81255a6947942b > For this reason I asked Josh if this commit was fixing distribution or was > a step in that direction but doesn't finish to solve the issue. > > > El dom., 21 jul. 2019 a las 21:06, Piotr Zarzycki (< > [email protected]>) escribió: > > > Hi Carlos, > > > > Without knowing even what were the changes they rather won't give valid > > SDK. Distribution have never been finished and work as a valid SDK. I was > > using distribution only as a source of code intelligence a way back in > > Intellij, cause that IDE were able to use it even it it wasn't fully > valid > > sdk. > > > > Thanks, > > Piotr > > > > niedz., 21 lip 2019 o 21:02 Carlos Rovira <[email protected]> > > napisał(a): > > > > > Hi Josh, > > > > > > I saw your changes for maven distribution and today I want to try if I > > can > > > create a Royale SDK with Maven again. > > > > > > Using the following command line: > > > > > > mvn -s settings-template.xml -P build-distribution clean install > > > > > > I get a success build but I think is still not valid SDK since I open a > > > project in VSCode and as3mxml plugin seems does not recognize a project > > > like Core, Basic or Jewel. > > > > > > I tried as well with other folder and this time the build failed: > > > > > > [*INFO*] *--- *maven-assembly-plugin:2.6:single > > *(create-distro-packages)* > > > @ distribution* ---* > > > > > > [*INFO*] Reading assembly descriptor: src/main/assembly/bin.xml > > > > > > [*WARNING*] The following patterns were never triggered in this > artifact > > > exclusion filter: > > > > > > o 'org.apache.royale.framework:*:swc:typedefs' > > > > > > > > > [*INFO*] Building zip: > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/distribution/target/apache-royale-0.9.6-SNAPSHOT-bin.zip > > > > > > [*WARNING*] The following patterns were never triggered in this > artifact > > > exclusion filter: > > > > > > o 'org.apache.royale.framework:*:swc:typedefs' > > > > > > > > > [*INFO*] Building tar: > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/distribution/target/apache-royale-0.9.6-SNAPSHOT-bin.tar.gz > > > > > > [*INFO*] > > > > > > [*INFO*] *--- *maven-assembly-plugin:2.6:single > > > *(create-distribution-folder)* @ distribution* ---* > > > > > > [*INFO*] Reading assembly descriptor: src/main/assembly/dir.xml > > > > > > [*WARNING*] The following patterns were never triggered in this > artifact > > > exclusion filter: > > > > > > o 'org.apache.royale.framework:*:swc:typedefs' > > > > > > > > > [*WARNING*] The following patterns were never triggered in this > artifact > > > inclusion filter: > > > > > > o 'com.adobe.air.compiler:adt:zip:win' > > > > > > > > > [*WARNING*] NOTE: Your assembly specifies a dependencySet that matches > > > multiple artifacts, but specifies a concrete output format. THIS MAY > > RESULT > > > IN ONE OR MORE ARTIFACTS BEING OBSCURED! > > > > > > > > > Output directory: 'null' > > > > > > Output filename mapping: 'frameworks' > > > > > > [*WARNING*] The following patterns were never triggered in this > artifact > > > inclusion filter: > > > > > > o 'com.adobe.air.runtime:adl:exe:win' > > > > > > > > > [*WARNING*] The following patterns were never triggered in this > artifact > > > inclusion filter: > > > > > > o 'com.adobe.air.runtime:air:zip:win' > > > > > > > > > [*WARNING*] The following patterns were never triggered in this > artifact > > > inclusion filter: > > > > > > o 'com.adobe.air.runtime:air-captive:zip:win' > > > > > > > > > [*WARNING*] The following patterns were never triggered in this > artifact > > > inclusion filter: > > > > > > o 'com.adobe:fontkit' > > > > > > > > > [*INFO*] Copying files to /Usuarios/carlosrovira/Dev/Royale/Sdks/. > > > > > > [*INFO*] > > > > > > *------------------------------------------------------------------------* > > > > > > [*INFO*] *Reactor Summary for Apache Royale: Framework: Parent > > > 0.9.6-SNAPSHOT:* > > > > > > [*INFO*] > > > > > > [*INFO*] Apache Royale: Framework: Parent ................... > *SUCCESS* [ > > > 2.639 s] > > > > > > [*INFO*] compc .............................................. > *SUCCESS* [ > > > 1.441 s] > > > > > > [*INFO*] compiler-asc ....................................... > *SUCCESS* [ > > > 0.492 s] > > > > > > [*INFO*] compiler-compc ..................................... > *SUCCESS* [ > > > 0.391 s] > > > > > > [*INFO*] compiler-mxmlc ..................................... > *SUCCESS* [ > > > 0.407 s] > > > > > > [*INFO*] compiler-optimizer ................................. > *SUCCESS* [ > > > 0.392 s] > > > > > > [*INFO*] compiler-swfdump ................................... > *SUCCESS* [ > > > 0.387 s] > > > > > > [*INFO*] mxmlc .............................................. > *SUCCESS* [ > > > 0.517 s] > > > > > > [*INFO*] Apache Royale: Distribution ........................ > *FAILURE* [ > > > 10.650 s] > > > > > > [*INFO*] > > > > > > *------------------------------------------------------------------------* > > > > > > [*INFO*] *BUILD FAILURE* > > > > > > [*INFO*] > > > > > > *------------------------------------------------------------------------* > > > > > > [*INFO*] Total time: 17.383 s > > > > > > [*INFO*] Finished at: 2019-07-21T20:55:50+02:00 > > > > > > [*INFO*] > > > > > > *------------------------------------------------------------------------* > > > > > > [*ERROR*] Failed to execute goal > > > org.apache.maven.plugins:maven-assembly-plugin:2.6:single > > > *(create-distribution-folder)* on project distribution: *Failed to > create > > > assembly: Error creating assembly archive dir: Unable to create > directory > > > or parent directory of > > > > > > > > > /Usuarios/carlosrovira/Dev/Royale/Sdks/frameworks/manifests/basic-manifest-binding.xml* > > > -> *[Help 1]* > > > > > > Seems using target folder option is now broken > > > > > > I want to ask you if your recent fixes was making distribution for you > to > > > work or there's still some work to do. In that case do you know what's > > > missing to make it work as ANT sdk creation? > > > > > > thanks > > > > > > > > > -- > > > Carlos Rovira > > > http://about.me/carlosrovira > > > > > > > > > -- > > > > Piotr Zarzycki > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > <https://www.patreon.com/piotrzarzycki>* > > > > > -- > Carlos Rovira > http://about.me/carlosrovira >
