ChinmayHegde24 commented on code in PR #901:
URL: https://github.com/apache/ranger/pull/901#discussion_r3058723270
##########
security-admin/src/test/java/org/apache/ranger/security/web/filter/TestRangerSSOAuthenticationFilter.java:
##########
@@ -498,4 +498,9 @@ public void
testDoFilter_ssoDisabled_locallogin_redirectsToLoginJsp() throws Exc
verify(res, times(1)).sendRedirect("/login.jsp");
verify(chain, times(0)).doFilter(any(ServletRequest.class),
any(ServletResponse.class));
}
+
+ @Test
Review Comment:
Yes thank you so much @kumaab for reviewing this PR, Unit tests for
**validateIssuer()** are not added in this PR as the **ranger-authn** module
currently has no test coverage. This is being tracked separately under
RANGER-5548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
