kumaab commented on code in PR #899:
URL: https://github.com/apache/ranger/pull/899#discussion_r3018763800


##########
authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerEmbeddedAuthorizer.java:
##########


Review Comment:
   `ConcurrentHashMap` here offers better concurrency and scalability as it 
uses fine-grained locking mechanism (lock striping) as compared to 
`synchronized` on `plugins` in L219 which synchronizes on the whole map. It's 
suggested to use `ConcurrentHashMap` and simplifying `getOrCreatePlugin()` 
accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to