+1,
Environment: MacOS 10.13.1
Checked:
* CRCs: md5 and sha1,
* Bin distribution:
- Start standalone service and producer/consumer test
* Src distribution:
- Compile and unit tests
- RAT check
- Start standalone service
PS, RAT check passed on my check.
But some 2 small issues that I met:
1, seems gpg signature need signed by others.
```
gpg --verify apache-pulsar-1.21.0-incubating-bin.tar.gz.asc
apache-pulsar-1.21.0-incubating-bin.tar.gz
gpg: Signature made Thu Nov 30 13:25:16 2017 CST
gpg: using RSA key 000A0885253005EBF749E283A92D27AAC3D80414
gpg: Good signature from "Nozomi Kurihara (CODE SIGNING KEY) <
[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
Primary key fingerprint: 000A 0885 2530 05EB F749 E283 A92D 27AA C3D8 0414
```
2, some findbugs error reporting for src, by command "mvn findbugs:check ":
```
[INFO] com.scurrilous.circe.HashSupport$SetComparator implements Comparator
but not Serializable [com.scurrilous.circe.HashSupport$SetComparator] At
HashSupport.java:[lines 173-176] SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
[INFO] com.scurrilous.circe.params.SimpleHashParameters.equals(Object)
fails for subtypes [com.scurrilous.circe.params.SimpleHashParameters] At
SimpleHashParameters.java:[line 51] EQ_GETCLASS_AND_CLASS_CONSTANT
[INFO]
org.apache.pulsar.checksum.utils.NativeUtils.loadLibraryFromJar(String) may
fail to clean up java.io.InputStream on checked exception
[org.apache.pulsar.checksum.utils.NativeUtils,
org.apache.pulsar.checksum.utils.NativeUtils,
org.apache.pulsar.checksum.utils.NativeUtils] Obligation to clean up
resource created at NativeUtils.java:[line 62] is not dischargedPath
continues at NativeUtils.java:[line 63]Path continues at
NativeUtils.java:[line 67] OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE
[INFO] Exceptional return value of java.io.File.delete() ignored in
org.apache.pulsar.checksum.utils.NativeUtils.loadLibraryFromJar(String)
[org.apache.pulsar.checksum.utils.NativeUtils] At NativeUtils.java:[line
51] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE
[INFO]
```
On Fri, Dec 1, 2017 at 10:29 AM, Nozomi Kurihara <[email protected]>
wrote:
> Hi Dave,
>
>
> Thanks for your detailed check.
>
>
> However, I have not seen
>
>
> > - rat check.
>
> > Files missing headers: dependency-reduced-pom.xml which is generated.
> > Please add an exclude to the pom.xml:
> > 720d719
> > < <exclude>**/dependency-reduced-pom.xml</exclude>
>
> by executing $mvn apache-rat:check in the src package.
> Could you tell me the reproducing procedure?
>
> Thanks,
> Nozomi
>
> ________________________________
> 差出人: Dave Fisher <[email protected]>
> 送信日時: 2017年12月1日 8:37:50
> 宛先: [email protected]
> 件名: Re: [VOTE] Pulsar 1.21.0-incubating Release Candidate 2
>
> +1 (IPMC Binding)
>
> Environment: macOS 10.12.6
>
> Checked all signatures and check sums - SHA is 512 bits.
>
> BIN distribution.
> - NOTICE, README, LICENSE and DISCLAIMER.
> ——> Binary licenses are in a subdirectory and probably ought to be in the
> full LICENSE file. For next time IMHO.
> - Started the standalone service - I’m not sure how well it worked, but
> had a lot of INFO log messages.
>
> SRC distribution
> - NOTICE. README, LICENSE and DISCLAIMER
> - mvn install - all tests passed.
> - rat check.
> Files missing headers: dependency-reduced-pom.xml which is generated.
> Please add an exclude to the pom.xml:
> 720d719
> < <exclude>**/dependency-reduced-pom.xml</exclude>
>
> - Started the standalone service - looked similar to the bin results.
>
> It is up to the Release Manager to decide to fix the exclude now and recut
> the release or wait until next release.
> I also recommend removing the inactive license check plugin -
> license-maven-plugin
>
> Regards,
> Dave
>
> On Nov 30, 2017, at 10:00 AM, Matteo Merli <[email protected]<mailto:
> [email protected]>> wrote:
>
> +1 (binding)
>
> Environment: MacOS 10.12
>
> Checked:
> * Signatures, crc
> * Bin distribution:
> - NOTICE, README, LICENSE
> - Start standalone service and producer/consumer test
> * Src distribution:
> - NOTICE, README, LICENSE
> - Compile and unit tests
> - RAT check
> - Start standalone service
> * Checked staging maven repository artifacts
>
> Matteo
>
>
> On Wed, Nov 29, 2017 at 9:57 PM Nozomi Kurihara <[email protected]<
> mailto:[email protected]>>
> wrote:
>
> This is the THIRD release candidate for Apache Pulsar, version
> 1.21.0-incubating.
>
> It fixes the following issues:
> https://github.com/apache/incubator-pulsar/milestone/10?closed=1
>
> *** Please download, test and vote by December 5th 2017, 10:00 GMT.
>
> Note that we are voting upon the source (tag), binaries are provided for
> convenience.
>
> Source and binary files:
>
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> pulsar-1.21.0-incubating-candidate-2/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachepulsar-1004/
>
> The tag to be voted upon:
> v1.21.0-incubating-candidate-2 (be96bd38b1f97b1b0888565196d77419004abe88)
>
> https://github.com/apache/incubator-pulsar/releases/tag/
> v1.21.0-incubating-candidate-2
>
> Pulsar's KEYS file containing PGP keys we use to sign the release:
> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
>
> Please download the the source package, and follow the README to build and
> run the Pulsar standalone service.
>
> Thanks,
> Nozomi
>
> --
> Matteo Merli
> <[email protected]<mailto:[email protected]>>
>
>
