[
https://issues.apache.org/jira/browse/PIO-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142123#comment-16142123
]
ASF GitHub Bot commented on PIO-110:
------------------------------------
Github user mars commented on the issue:
https://github.com/apache/incubator-predictionio/pull/425
Great Scala-style improvements here, @takezoe. Great to see this gardening
of the codebase 🤓
I'm wondering, in [PIO-110](https://issues.apache.org/jira/browse/PIO-110)
the objective is to refactor the common code between `CreateServer` and
`BatchPredict`, yet I do not see that kind of change here. Are you working on
extracting & reusing the common code as the next step for this PR?
> Refactor common code shared by CreateServer and BatchPredict
> ------------------------------------------------------------
>
> Key: PIO-110
> URL: https://issues.apache.org/jira/browse/PIO-110
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.12.0-incubating
> Reporter: Donald Szeto
> Assignee: Naoki Takezoe
> Labels: newbie
>
> {{BatchPredict}} was created in PIO-105 and has a substantial amount of
> shared code with {{CreateServer}}. It would be beneficial to refactor both of
> them to share as much common code as possible.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
