[ 
https://issues.apache.org/jira/browse/PIO-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056806#comment-16056806
 ] 

ASF GitHub Bot commented on PIO-92:
-----------------------------------

Github user takezoe commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/391
  
    @pferrel Following methods have been deprecated since HBase 1.0.0. Since 
they are still alive in HBase 1.2.6 current code works fine with 1.2.6.
    
    I think it's not necessary to merge this request soon, but HBase 0.98 
hasn't been maintained in fact. So we should lead users to upgrade to 
maintained versions. At first, we should announce the plan of supported 
versions and drop old versions after a sufficient transition period. Maybe we 
should do it after graduation the incubator. I would like to keep this changes 
keeps until that time.
    
    But I think that there is no problem to upgrade HBase dependency to 1.2.6 
from 0.98, so I will create another pull request to only do it.
    
    ```
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBEventsUtil.scala:167:
 method add in class Put is deprecated: see corresponding Javadoc for more 
information.
    [warn]       put.add(eBytes, col, Bytes.toBytes(v))
    [warn]           ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBEventsUtil.scala:171:
 method add in class Put is deprecated: see corresponding Javadoc for more 
information.
    [warn]       put.add(eBytes, col, Bytes.toBytes(v))
    [warn]           ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBLEvents.scala:45:
 trait HTableInterface in package client is deprecated: see corresponding 
Javadoc for more information.
    [warn]   def getTable(appId: Int, channelId: Option[Int] = None): 
HTableInterface =
    [warn]                                                            ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBLEvents.scala:106:
 method flushCommits in trait HTableInterface is deprecated: see corresponding 
Javadoc for more information.
    [warn]       table.flushCommits()
    [warn]             ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBLEvents.scala:120:
 method flushCommits in trait HTableInterface is deprecated: see corresponding 
Javadoc for more information.
    [warn]       table.flushCommits()
    [warn]             ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBPEvents.scala:122:
 constructor HTable in class HTable is deprecated: see corresponding Javadoc 
for more information.
    [warn]       val table = new HTable(conf, tableName)
    [warn]                   ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/StorageClient.scala:36:
 trait HConnection in package client is deprecated: see corresponding Javadoc 
for more information.
    [warn]   val connection: HConnection,
    [warn]                   ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/StorageClient.scala:34:
 trait HConnection in package client is deprecated: see corresponding Javadoc 
for more information.
    [warn] case class HBClient(
    [warn]            ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/StorageClient.scala:76:
 method createConnection in object HConnectionManager is deprecated: see 
corresponding Javadoc for more information.
    [warn]   val connection = HConnectionManager.createConnection(conf)
    [warn]                                       ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/StorageClient.scala:81:
 constructor HBaseAdmin in class HBaseAdmin is deprecated: see corresponding 
Javadoc for more information.
    [warn]     admin = new HBaseAdmin(connection)
    [warn]             ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/upgrade/HB_0_8_0.scala:51:
 trait HConnection in package client is deprecated: see corresponding Javadoc 
for more information.
    [warn]     connection: HConnection,
    [warn]                 ^
    [warn] 
/Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/upgrade/Upgrade.scala:70:
 method flushCommits in trait HTableInterface is deprecated: see corresponding 
Javadoc for more information.
    [warn]     newTable.flushCommits()
    [warn]              ^
    [warn] 12 warnings found
    ```


> HBase version is too old
> ------------------------
>
>                 Key: PIO-92
>                 URL: https://issues.apache.org/jira/browse/PIO-92
>             Project: PredictionIO
>          Issue Type: Improvement
>    Affects Versions: 0.11.0-incubating
>            Reporter: Naoki Takezoe
>
> The current HBase storage implementation in PredictionIO has dependencies to 
> HBase 0.98.5, but it's already EOM. We should upgrade it to 1.2 at least.
> Here is the status of HBase and Hadoop versions:
> http://hbase.apache.org/book.html#hadoop 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to