GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/362
Move storage depended tests to each storage project
Some tests are failed to compile in the develop branch:
```
[error]
/Users/naoki.takezoe/incubator-predictionio/data/src/test/scala/org/apache/predictionio/data/storage/StorageTestUtils.scala:22:
not found: object scalikejdbc
[error] import scalikejdbc._
[error] ^
[error]
/Users/naoki.takezoe/incubator-predictionio/data/src/test/scala/org/apache/predictionio/data/storage/StorageTestUtils.scala:21:
object hbase is not a member of package org.apache.predictionio.data.storage
[error] import org.apache.predictionio.data.storage.hbase.HBLEvents
[error] ^
[error]
/Users/naoki.takezoe/incubator-predictionio/data/src/test/scala/org/apache/predictionio/data/storage/StorageTestUtils.scala:30:
not found: type HBLEvents
[error] Error occurred in an application involving default arguments.
[error] .asInstanceOf[HBLEvents]
[error] ^
[error]
/Users/naoki.takezoe/incubator-predictionio/data/src/test/scala/org/apache/predictionio/data/storage/StorageTestUtils.scala:42:
not found: value DB
[error] def dropJDBCTable(table: String): Unit = DB autoCommit { implicit
s =>
[error] ^
[error] four errors found
```
It looks caused by some dependencies has been moved to storage sub
projects, so I separated and moved storage depended tests to each storage
projects.
However since I don't know to correct way to run these tests, I couldn't
confirm to whether these tests succeed or not. To begin with, being these tests
maintained?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio
move-storage-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit f6732c73635f5b7979203c29ccf4d654617122b0
Author: Naoki Takezoe <[email protected]>
Date: 2017-03-15T00:54:15Z
Move storage depended tests to each storage project
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
