GitHub user mars opened a pull request:
https://github.com/apache/incubator-predictionio-template-skeleton/pull/5
Example Tests
This skeleton repo seems to be the authoritative starting point for
creating a new engine. Since testing is a great way to improve collaboration
and reliability, what do you think about including example tests in the
skeleton?
Here I implemented tests with a [ScalaTest](http://www.scalatest.org) suite
which includes a mixin `SharedSingletonContext` to make a Spark context
available as `SparkContext`.
Each of the engine-defined classes now has a tiny passing test:
`AlgorithmTest`, `EngineTest`, `PreparatorTest`, & `ServingTest`.
`DataSourceTest` is the outlier and so currently tagged **ignore**. It's
difficult to test in the skeleton, because it requires a database connection as
well as database cleansing or transaction isolation between tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mars/incubator-predictionio-template-skeleton
example-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio-template-skeleton/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit a6954e9bc7bd53fc47e5150f6132757e740b42a5
Author: Mars Hall <[email protected]>
Date: 2017-03-08T21:29:45Z
Implement tests in template skeleton.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
