[ 
https://issues.apache.org/jira/browse/PIO-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878996#comment-15878996
 ] 

ASF GitHub Bot commented on PIO-49:
-----------------------------------

Github user pferrel commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/336
  
    The current problem is linking them both in and putting them into the 
assembly. PIO, including assemblies should be built with one or the other, not 
both. Not sure how plugins fixes this.
    
    I'm no SBT expert but this is pretty easy and common to solve with maven 
profiles. You would build pulling in certain classes for es1 and others for 
es5. 
    
    This means templates will need to be changed if they use any of the things 
that change for es1 vs es5 and I maintain one. This is ok, it's seems like the 
right way to do this.


> Add support for Elasticsearch 5.x
> ---------------------------------
>
>                 Key: PIO-49
>                 URL: https://issues.apache.org/jira/browse/PIO-49
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Shinsuke Sugaya
>
> We work on meta/event storage support for Elasticsearch 5.x.
> Although Elasticsearch 2.x does not allow dots in field names,
> Elasticsearch 5.x supports it. So, it's better to upgrade to ES 5.x release.
> Since ES 5.x provides Java Rest API client, we replaced
> Transport communication with HTTP one. Therefore, our fix
> uses HTTP(9200 port) only.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to