[ 
https://issues.apache.org/jira/browse/PIO-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828992#comment-15828992
 ] 

ASF GitHub Bot commented on PIO-49:
-----------------------------------

Github user dszeto commented on a diff in the pull request:

    
https://github.com/apache/incubator-predictionio/pull/336#discussion_r96753275
  
    --- Diff: data/build.sbt ---
    @@ -18,41 +18,45 @@
     name := "apache-predictionio-data"
     
     libraryDependencies ++= Seq(
    -  "com.github.nscala-time" %% "nscala-time"    % "2.6.0",
    -  "commons-codec"           % "commons-codec"  % "1.9",
    -  "io.spray"               %% "spray-can"      % "1.3.3",
    -  "io.spray"               %% "spray-routing"  % "1.3.3",
    -  "io.spray"               %% "spray-testkit"  % "1.3.3" % "test",
    -  "mysql"                   % "mysql-connector-java" % "5.1.37" % 
"optional",
    -  "org.apache.hadoop"       % "hadoop-common"  % "2.6.2"
    +  "com.github.nscala-time"  %% "nscala-time"    % "2.6.0",
    +  "commons-codec"            % "commons-codec"  % "1.9",
    +  "io.spray"                %% "spray-can"      % "1.3.3",
    +  "io.spray"                %% "spray-routing"  % "1.3.3",
    +  "io.spray"                %% "spray-testkit"  % "1.3.3" % "test",
    +  "mysql"                    % "mysql-connector-java" % "5.1.37" % 
"optional",
    +  "org.apache.hadoop"        % "hadoop-common"  % "2.6.2"
         exclude("javax.servlet", "servlet-api"),
    -  "org.apache.hbase"        % "hbase-common"   % "0.98.5-hadoop2",
    -  "org.apache.hbase"        % "hbase-client"   % "0.98.5-hadoop2"
    +  "org.apache.hbase"         % "hbase-common"   % "0.98.5-hadoop2",
    +  "org.apache.hbase"         % "hbase-client"   % "0.98.5-hadoop2"
         exclude("org.apache.zookeeper", "zookeeper"),
       // added for Parallel storage interface
    -  "org.apache.hbase"        % "hbase-server"   % "0.98.5-hadoop2"
    +  "org.apache.hbase"         % "hbase-server"   % "0.98.5-hadoop2"
         exclude("org.apache.hbase", "hbase-client")
         exclude("org.apache.zookeeper", "zookeeper")
         exclude("javax.servlet", "servlet-api")
         exclude("org.mortbay.jetty", "servlet-api-2.5")
         exclude("org.mortbay.jetty", "jsp-api-2.1")
         exclude("org.mortbay.jetty", "jsp-2.1"),
    -  "org.apache.zookeeper"    % "zookeeper"      % "3.4.7"
    +  "org.apache.zookeeper"     % "zookeeper"      % "3.4.7"
         exclude("org.slf4j", "slf4j-api")
         exclude("org.slf4j", "slf4j-log4j12"),
    -  "org.apache.spark"       %% "spark-core"     % sparkVersion.value % 
"provided",
    -  "org.apache.spark"       %% "spark-sql"      % sparkVersion.value % 
"provided",
    -  "org.clapper"            %% "grizzled-slf4j" % "1.0.2",
    -  "org.elasticsearch"       % "elasticsearch"  % 
elasticsearchVersion.value,
    -  "org.json4s"             %% "json4s-native"  % json4sVersion.value,
    -  "org.json4s"             %% "json4s-ext"     % json4sVersion.value,
    -  "org.postgresql"          % "postgresql"     % "9.4-1204-jdbc41",
    -  "org.scalatest"          %% "scalatest"      % "2.1.7" % "test",
    -  "org.scalikejdbc"        %% "scalikejdbc"    % "2.3.5",
    -  "org.slf4j"               % "slf4j-log4j12"  % "1.7.18",
    -  "org.spark-project.akka" %% "akka-actor"     % "2.3.4-spark",
    -  "org.specs2"             %% "specs2"         % "2.3.13" % "test")
    +  "org.apache.spark"        %% "spark-core"     % sparkVersion.value % 
"provided",
    +  "org.apache.spark"        %% "spark-sql"      % sparkVersion.value % 
"provided",
    +  "org.clapper"             %% "grizzled-slf4j" % "1.0.2",
    +  "org.elasticsearch.client" % "rest"           % 
elasticsearchVersion.value,
    +  "org.elasticsearch"        % "elasticsearch"  % 
elasticsearch1Version.value,
    +  "org.elasticsearch"        % "elasticsearch-spark-13_2.10" % 
elasticsearchVersion.value % "provided",
    --- End diff --
    
    We could do
    ```
    "org.elasticsearch"       %% "elasticsearch-spark-13" % 
elasticsearchVersion.value % "provided",
    ```
    We do not need to change this now because PIO-30 will need to be extended 
to take care of cross-building, and the whole artifact name will need to change.


> Add support for Elasticsearch 5.x
> ---------------------------------
>
>                 Key: PIO-49
>                 URL: https://issues.apache.org/jira/browse/PIO-49
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Shinsuke Sugaya
>
> We work on meta/event storage support for Elasticsearch 5.x.
> Although Elasticsearch 2.x does not allow dots in field names,
> Elasticsearch 5.x supports it. So, it's better to upgrade to ES 5.x release.
> Since ES 5.x provides Java Rest API client, we replaced
> Transport communication with HTTP one. Therefore, our fix
> uses HTTP(9200 port) only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to