So it looks like earlier in the process of fixing this for JDBC I broke it for HBase. Still not quite sure why, but it appears that inserting events without eventIds is the cause of the deletion. Regardless, I just moved the event id stripping to JDBCPEvents (to fix insert errors in JDBC). Also added a test case which fails before this fix. Committed and pushed. Tests passed locally, Travis is running right now. Will close the JIRA when I see it complete.
On Wed, Nov 23, 2016 at 11:42 AM, Alex Merritt <[email protected]> wrote: > I first took a quick look at the merge, and it looked like the only > (minor) divergence is in JDBC. And yet, I assume you are using HBase here. > As was I, when I was later able to reproduce the issue (using > SelfCleaningDataSourceTest). > > Will aim to track down & > attempt a fix today / tomorrow. > > Alex > > On Mon, Nov 21, 2016 at 5:16 PM, Alex Merritt <[email protected]> wrote: > >> Sure, I can try to reproduce this / take a look tomorrow. >> >> Alex >> >> On Nov 21, 2016 12:05 PM, "Pat Ferrel" <[email protected]> wrote: >> >>> Do you have time to look at this Alex? I may have made a mistake in >>> merging this feature. At present any use of it erases all data. Since it is >>> only used from templates we haven’t had one that used it except your >>> integration test that should be merged with Apache-PIO. Can you at least >>> run those to see if the problem is reproducible? Or tell me how to run >>> those? It’s included in one of the example templates, right? >>> >>> >>> On Nov 20, 2016, at 5:30 PM, Pat Ferrel (JIRA) <[email protected]> wrote: >>> >>> >>> [ https://issues.apache.org/jira/browse/PIO-45?page=com.atlass >>> ian.jira.plugin.system.issuetabpanels:all-tabpanel ] >>> >>> Pat Ferrel updated PIO-45: >>> -------------------------- >>> Description: >>> as integrated into the UR, in the integration-test, the >>> SelfCleaningDataset erases all data. This feature works fine in the AML >>> version of PIO. >>> >>> Although not tested one could assume that this would be true with any >>> other Datasource in other templates. >>> >>> [~emergentorder] can you check to see if the PIO merge was done >>> correctly. >>> >>> was: >>> as integrated into the UR, in the integration-test, the >>> SelfCleaningDataset erases all data. This feature works fine in the AML >>> version of PIO. >>> >>> Although not tested one could assume that this would be true with any >>> other Datasource in other templates. >>> >>> [~amerritt] can you check to see if the PIO merge was done correctly. >>> >>> >>> > SelfCleaningDatasource erases all data >>> > -------------------------------------- >>> > >>> > Key: PIO-45 >>> > URL: https://issues.apache.org/jira/browse/PIO-45 >>> > Project: PredictionIO >>> > Issue Type: Bug >>> > Affects Versions: 0.10.0-incubating >>> > Reporter: Pat Ferrel >>> > Assignee: Alexander Merritt >>> > Priority: Critical >>> > Fix For: 0.11.0 >>> > >>> > >>> > as integrated into the UR, in the integration-test, the >>> SelfCleaningDataset erases all data. This feature works fine in the AML >>> version of PIO. >>> > Although not tested one could assume that this would be true with any >>> other Datasource in other templates. >>> > [~emergentorder] can you check to see if the PIO merge was done >>> correctly. >>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.3.4#6332) >>> >>> >
