Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/271
Great discussion here. We should update the contributor guideline regarding
the choice of merging and squashing.
I believe Apache does not enforce how pull requests should be handled, and
it is up to committers to pick a style. Typically squashing is good for a
single author branch so that it is easier (debatable :)) for other people to
read what is changed for a particular ticket. For multi-author branches, I echo
with @jamesward that it should not be squashed, as it is impossible to credit
the squashed commit to multiple authors.
@HyukjinKwon, if you wouldn't mind please cherry pick those commits into a
branch and I will merge them instead of squashing. Apologies to everyone for
the confusion and we will improve guidelines as we march forward to our first
ASF release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
