We can also make these templates part of the integration test that Chan and Marcin just submitted ( https://github.com/apache/incubator-predictionio/pull/267). That way we can make commitment to included templates be part of every committer's effort. Just my 2c.
On Sun, Aug 7, 2016 at 9:47 AM, Pat Ferrel <[email protected]> wrote: > If this sound ok, I propose the process be: > 1) inclusion in the gallery is a PR to the yaml gallery file. This is > reviewable by all but takes only one committer to approve and merge. > 2) submission for inclusion in the project can be a PR to the new > templates directory as Simon suggests. But this may require a more formal > vote, and come with some commitment for support and possibly consideration > of the author for committer status. > > Someone who knows Apache rules better than me may know the type of vote to > have for #2, maybe this is only informal review and single committer > acceptance too as long as the committer is willing to support the template. > > As far as the Salesforce templates marked official, I’d hope that most > would be donated. According to the proposed rules all we need is a PR for > each. And again a big thanks to Salesforce! > > > On Aug 4, 2016, at 2:55 PM, Pat Ferrel <[email protected]> wrote: > > Actually this is mostly a fine idea but I think the bigger question is how > do we treat templates in general. > > IMO the maintaining author can decide to contribute them or not and the > committers can decide to accept or not. For example in the case of the UR I > may decide to support and maintain it outside of Apache while some from > Salesforce might be submitted as donations. Donation comes at some > obligation. There are lots of examples in Mahout of algorithms whose > authors no longer support them. These are slowly being deprecated and > removed so I’d like to see a method that avoids this issue. > > If we allow maintainers to submit templates to the Gallery with a link to > code as well as support then donating the template code to Apache is > independent of acceptance to the Gallery. Any template donated to Apache > should come with some commitment by the author to support it there > indefinitely and perhaps even acceptance as a PIO committer—and if they > disappear or don’t support the template it is easy to deprecate/remove. > > That means if Salesforce wants to donate the templates it maintains—great. > Personally I'd would vote for acceptance of most of them. Then the support > link can be to the Apache user list or instructions for joining it. If a > maintainer wants to stay out of the Apache repo and support separately then > this is possible also. With all templates treated equally—official or > not—and there is a route to becoming official for non-official ones. > > BTW it might be good to remove the “official” designation in favor of > “Apache supported” or the PredictionIO logo or something like that. We > really need to encourage template development even if they are not code > contributions. > > > On Aug 3, 2016, at 3:32 PM, Simon Chan <[email protected]> wrote: > > Hey guys, > > I just want to start the discussion about moving previously "official" > PredictionIO engine templates into Apache. > > Official templates are those marked "Official" here: > http://templates.prediction.io/ > > In order to move them to ASF Git, would the best way be creating > sub-directory under PredictionIO repo? > > Simon > > >
