Github user pferrel commented on a diff in the pull request:

    
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793210
  
    --- Diff: data/src/main/scala/io/prediction/data/storage/PEvents.scala ---
    @@ -179,4 +179,8 @@ trait PEvents extends Serializable {
         */
       @DeveloperApi
       def write(events: RDD[Event], appId: Int, channelId: Option[Int])(sc: 
SparkContext): Unit
    +
    +  @DeveloperApi 
    +  def delete(eventIds: RDD[String], appId: Int, channelId: 
Option[Int])(sc: SparkContext): Unit
    +
     }
    --- End diff --
    
    ready for review
    
    Fixes a problem in the example Cleanup App, where it has to do 
`rdd.collect` to actually delete events. Collect does not scale.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to