Hi All, Since no concerns have been raised here and the PR has been approved, I'll be merging it as soon as CI passes (it needs a rebase due to recent changes in CI checks).
Cheers, Dmitri. On Thu, Feb 5, 2026 at 8:32 AM Alexandre Dutra <[email protected]> wrote: > Hi all, > > I also am in favor of the breaking change, since our evolution > guidelines [1] authorize such changes. > > Thanks, > Alex > > [1]: > https://polaris.apache.org/releases/1.3.0/evolution/#using-polaris-as-a-build-time-dependency > > On Tue, Feb 3, 2026 at 11:07 PM Dmitri Bourlatchkov <[email protected]> > wrote: > > > > Thanks for opening this discussion, Yong! > > > > I support this change (you'll notice that I proposed it in GH comments). > > > > Cheers, > > Dmitri. > > > > On Mon, Feb 2, 2026 at 9:37 PM Yong Jin Lee via dev < > [email protected]> > > wrote: > > > > > Hi, > > > > > > I’m working on PR #3480 <https://github.com/apache/polaris/pull/3480>, > > > which adds proxy configuration support for federated catalogs (issue > #3465 > > > <https://github.com/apache/polaris/issues/3465>). The PR takes a > > > *breaking-change* approach for ExternalCatalogFactory rather than a > > > deprecation path. > > > > > > *Change summary* > > > > > > `ExternalCatalogFactory` Methods now include a catalogProperties > parameter: > > > > > > Before: > > > > > > - > > > > > > createCatalog(ConnectionConfigInfoDpo, PolarisCredentialManager) > > > - > > > > > > createGenericCatalog(ConnectionConfigInfoDpo, > PolarisCredentialManager) > > > > > > After: > > > > > > - > > > > > > createCatalog(ConnectionConfigInfoDpo, PolarisCredentialManager, > > > Map<String, String> catalogProperties) > > > - > > > > > > createGenericCatalog(ConnectionConfigInfoDpo, > PolarisCredentialManager, > > > Map<String, String> catalogProperties) > > > > > > *Rationale* > > > > > > This aligns with Polaris evolution expectations > > > <https://github.com/apache/polaris/blob/main/EVOLUTION.md> and avoids: > > > > > > - > > > > > > runtime WARN noise from deprecated methods on each catalog operation > > > - > > > > > > additional indirection/complexity from default-method delegation > > > > > > *Impact + migration* > > > > > > If you have an external implementation of ExternalCatalogFactory, > you’ll > > > need to update the method signatures and pass/merge catalogProperties > > > (e.g., > > > via RESTUtil.merge() with your existing properties). This enables > passing > > > HTTP client settings (proxy, timeouts, etc.) through to federated > catalog > > > connections. > > > > > > The PR has been reviewed and approved. Please let us know if there are > any > > > concerns. > > > > > > Thank you, > > > Yong-Jin > > > >
