[
https://issues.apache.org/jira/browse/PIG-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010552#comment-14010552
]
Aniket Mokashi edited comment on PIG-3958 at 5/28/14 12:15 AM:
---------------------------------------------------------------
We should be allowed to change method signatures of non-public methods.
Problem is that this test mocks behavior of jobClient's getTaskReport api using
mockito and then checks whether we get min, max, avg, mean correct or not.
getTaskReport from jobClient is broken in hadoop for local mode. With PIG-3913,
getTaskReport hides behind HadoopShims (to workaround hadoop issue) in a static
method which cannot be mocked (https://code.google.com/p/mockito/wiki/FAQ).
I will refactor the code a little bit to make this work.
was (Author: aniket486):
We should be allowed to change method signature of non-public methods.
Problem is that this test mocks behavior of jobClient's getTaskReport api using
mockito and then checks whether we get min, max, avg, mean correct or not.
getTaskReport from jobClient is broken in hadoop for local mode. With PIG-3913,
getTaskReport hides behind HadoopShims (to workaround hadoop issue) in a static
method which cannot be mocked (https://code.google.com/p/mockito/wiki/FAQ).
I will refactor the code a little bit to make this work.
> TestMRJobStats is broken in 0.13 and trunk
> ------------------------------------------
>
> Key: PIG-3958
> URL: https://issues.apache.org/jira/browse/PIG-3958
> Project: Pig
> Issue Type: Bug
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Fix For: 0.13.0, 0.14.0
>
>
> This is a regression of PIG-3913. It changed some method signature, and that
> breaks the unit test.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
