[
https://issues.apache.org/jira/browse/PIG-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277277#comment-13277277
]
Julien Le Dem commented on PIG-2705:
------------------------------------
Hi Josh
Thanks for the contribution.
This looks good to me.
I'd just not reuse the same variable name.
IE: something like that
{code}
Object newSchema = ((pf.__call__(Py.java2py(input))).__tojava__(Object.class));
if (newSchema instanceof ResourceSchema) {
return Schema.getPigSchema((ResourceSchema) newSchema);
} else if (newSchema instanceof Schema) {
return (Schema) newSchema;
} else {
return Utils.getSchemaFromString(newSchema.toString());
}
{code}
> outputSchema modification from scripting UDFs
> ---------------------------------------------
>
> Key: PIG-2705
> URL: https://issues.apache.org/jira/browse/PIG-2705
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.2, 0.10.0
> Reporter: Josh Levy
> Attachments: PIG-2705-1.patch
>
>
> The examples for @schemaFunction that I've seen on the web
> (http://pig.apache.org/docs/r0.10.0/udf.html#decorators) tend to be trivial
> ones that return the same schema passed in. I had a problem where I wrote a
> python udf that added a new field into a tuple in a bag. I ended up not
> specifying schema in python and then casting in pig. How does the community
> feel about making it easier to generate a dynamic schema from a scripting UDF?
> This could be done by modifying JythonFunction.outputSchema to handle
> outputSchemaFunc returning a string like @outputSchema does, or by exposing a
> public api that makes it easier to manipulate
> org.apache.pig.impl.logicalLayer.schema.Schema
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
