lengyuexuexuan commented on code in PR #2380:
URL:
https://github.com/apache/incubator-pegasus/pull/2380#discussion_r3026921151
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -234,6 +255,48 @@ void
pegasus_mutation_duplicator::on_duplicate_reply(uint64_t hash,
}
}
+void
pegasus_mutation_duplicator::log_non_idempotent_rpc_retry_if_need(duplicate_rpc
&rpc)
+{
+ if (!FLAGS_duplication_unsafe_allow_non_idempotent) {
+ return;
+ }
+
+ for (const auto &entry : rpc.request().entries) {
Review Comment:
If we log every time, the log volume could become very high when the QPS of
non-idempotent operations is significant. Could we switch to probabilistic
logging instead?
Like
https://github.com/apache/incubator-pegasus/blob/89f17c7722af064d326c0dbbdb147f4d1b207ee7/src/server/pegasus_mutation_duplicator.cpp#L202-L206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
