WHBANG commented on code in PR #1378:
URL:
https://github.com/apache/incubator-pegasus/pull/1378#discussion_r1122579429
##########
src/common/json_helper.h:
##########
@@ -493,6 +494,26 @@ inline bool json_decode(const JsonObject &in, std::set<T>
&t)
return true;
}
+template <typename T1, typename T2>
+inline void json_encode(JsonWriter &out, const std::unordered_set<T1, T2> &t)
Review Comment:
I don't agree, the template type is too deep, it will only increase the
complexity of code reading, not friendly to developers and viewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
