acelyc111 commented on code in PR #1356: URL: https://github.com/apache/incubator-pegasus/pull/1356#discussion_r1118437478
########## docker/pegasus-build-env/centos6/Dockerfile: ########## @@ -76,12 +76,6 @@ ENV MAVEN_HOME=/opt/rh/rh-maven33/root/usr/ ENV PATH=$MAVEN_HOME/bin:$JAVA_HOME/bin:$GCC_HOME/bin:$PYTHON2_HOME/bin/:$PATH ENV LD_LIBRARY_PATH=$JAVA_HOME/jre/lib/amd64/server:$PYTHON2_HOME/lib64/:$LD_LIBRARY_PATH -RUN pip install --no-cache-dir cmake - -RUN wget --progress=dot:giga https://github.com/apache/thrift/archive/refs/tags/0.11.0.tar.gz -P /opt/thrift && \ Review Comment: This patch added these code: https://github.com/apache/incubator-pegasus/pull/1045 That's because cpp code link thrift in version 0.9.3 (build by thirdparty), java code use thrift 0.11.0 binary (download here) to generate code from *.thrift files. Although it's confused, we can improve the different version lib/bin in another patch, but it would better to keep the logic in this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
