WHBANG commented on code in PR #1320:
URL:
https://github.com/apache/incubator-pegasus/pull/1320#discussion_r1080949334
##########
src/client/partition_resolver_simple.cpp:
##########
@@ -311,28 +311,28 @@ void
partition_resolver_simple::query_config_reply(error_code err,
}
}
} else if (resp.err == ERR_OBJECT_NOT_FOUND) {
- LOG_ERROR("%s.client: query config reply, gpid = %d.%d, err = %s",
- _app_name.c_str(),
- _app_id,
- partition_index,
- resp.err.to_string());
+ LOG_ERROR_F("{}.client: query config reply, gpid = {}.{}, err =
{}",
Review Comment:
done
##########
src/failure_detector/failure_detector.cpp:
##########
@@ -227,13 +227,13 @@ void failure_detector::check_all_records()
is_time_greater_than(now,
record.last_send_time_for_beacon_with_ack) &&
now + _check_interval_milliseconds -
record.last_send_time_for_beacon_with_ack >
_lease_milliseconds) {
- LOG_ERROR("master %s disconnected, now=%" PRId64 ",
last_send_time=%" PRId64
- ", now+check_interval-last_send_time=%" PRId64,
- record.node.to_string(),
- now,
- record.last_send_time_for_beacon_with_ack,
- now + _check_interval_milliseconds -
- record.last_send_time_for_beacon_with_ack);
+ LOG_ERROR_F("master {} disconnected, now={:#018x},
last_send_time={:#018x}, "
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
