ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568367366
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
- sal_uLong ConvertToNew(); //
Textbausteine konvertieren
+ sal_uLong ConvertToNew(); // convert
AutoText entries (ger: Textbausteine)
- sal_uInt16 GetCount() const;
// Anzahl Textbausteine ermitteln
- sal_uInt16 GetIndex( const String& ) const; //
Index fuer Kurznamen ermitteln
+ sal_uInt16 GetCount() const;
// return amount of AutoText entries
+ sal_uInt16 GetIndex( const String& ) const; //
return Index of shortnames
sal_uInt16 GetLongIndex( const String& ) const; //Index fuer
Langnamen ermitteln
Review comment:
Maybe "Return index of longnames"?
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor
laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load
shellio.cxx
Review comment:
I'd just translate "HTML.vor" into "HTML template" and carry on
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor
laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load
shellio.cxx
Review comment:
I think that "laden shellio.txt" means "the code is loaded from
shellio.cxx". "Laden" refers to the code, not to the template data. In fact,
the function is defined in file main/sw/source/filter/basflt/shellio.cxx
Just my opinion, of course
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]