On 3/15/13 10:20 AM, Ariel Constenla-Haile wrote: > On Wed, Mar 13, 2013 at 02:30:26PM +0100, Jürgen Schmidt wrote: >> - a missing include of XInterface in the new IDL >> XMarkingAccess.idl, IDL compile error on Mac, surprising that it >> worked for you > > This is a bug, the one that removed the need for explicitly > inheriting from XInterface should have taken care for not needing > to include the IDL, what sounds like a non-sense (do not explicitly > inherit, but include the header!).
I agree that it's a bug > >> The interface name "XMarkingAccess" and the method name >> "invalidateMarkings" sounds somewhat strange but I have to >> confess that I don't have a much better name in place. Maybe >> somebody else has a good name in mind? > > IMHO what it does is more problematic than how it's named; see my > comment on the bug. issue https://issues.apache.org/ooo/show_bug.cgi?id=121733 you are correct with your concerns of using strings where of course other existing types would make more sense. Your sugggestion of using - a "LineColor" with value css::util::Color instead of Red, Green, Blue - "LinjeType" of type css::awt::FontUnderline @Kai, can you please take this into account and adapt the changes? Ariel is right that these changes would an improvement. Regarding your concern I don't agree completely. For me it's fine to allow some more tweaking from the extension. Where I agree is that it shouldn't conflict with other global settings or other SmartTags. I will also take a further look into the code... Thanks for your reply Ariel Juergen --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
