Github user jackowaya commented on the pull request:
https://github.com/apache/incubator-nifi/pull/70#issuecomment-120950010
Made many changes here, including I believe all of Joe's suggestions and
the majority of Ryan's. A few little notes:
* I wound up using Scanner to do the text parsing. I figured Scanner
probably knows better how to parse numbers than I do. However, that does mean
that text like "123 Fake Street" will convert to int which is a little
questionable. Should be easy to write up a full-regex version if we decide we
want that.
* The code for sending just the failed records down the error relationship
got a little nasty. It calls session.write on a copy of the incoming flowfile,
then completely ignores that flowfile and uses the failed records it collected
during the first pass through the input data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
