Github user joey commented on the pull request:
https://github.com/apache/incubator-nifi/pull/51#issuecomment-110892315
@rdblue and @joewitt See the latest. I think this addresses all of the
Ryan's feedback. I do have one open question:
Currently I'm stopping the Sinks and Sources in an `@OnUnscheduled`
callback, but I'm not sure if that's the right place to do it. I'm not sure
about the intention of the API generally, but the `TestRunner#run()` method
will call `@OnUnscheduled` callbacks immediately after the first call to
`Processor#onTrigger()`. That means that effectively only a single
`onTrigger()` happens in any of my tests. Should this be delayed until an
`@OnStopped` callback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
