Github user joewitt commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/28#issuecomment-74805392
  
    Aldrin - awesome!  I have created a branch and am reviewing the details 
now.  Regarding the update to nifi/LICENSE  - I think the correct place for the 
addition is nifi/nifi-assembly/LICENSE as this is a binary only dependency (as 
far as I can tell just yet).  The items in /nifi/LICENSE are only for source 
dependencies.  Will adjust that prior to merging.  Initial pass of all 
deps/licensing/notice looks good though.  Unit tests and sample data looks 
great too.    Really nice effort here - this will be very helpful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to