ccollins476ad commented on a change in pull request #2: Support verification of
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r298257906
##########
File path: image/create.go
##########
@@ -38,7 +38,7 @@ import (
type ImageCreator struct {
Body []byte
Version ImageVersion
- SigKeys []sec.SignKey
+ SigKeys []sec.PrivSignKey
Review comment:
I forgot to reply here in case others were following. @utzig and I
discussed this offline, and we concluded that while the current naming may not
be the most intuitive, we couldn't think of any obviously-better candidates.
So, for now we will keep the current names. If they prove too confusing, we
can always change them later!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
