jungm opened a new pull request, #1113: URL: https://github.com/apache/myfaces/pull/1113
https://issues.apache.org/jira/browse/MYFACES-4770 Backport of #1112 to 4.1.x. ## Summary Same change as on `main`: `ViewScopeCDIMap.put()` returns the previous value instead of the internal `ContextualInstanceInfo` wrapper. ```diff -return getCreationalContextInstances().put(beanKey, info); +ContextualInstanceInfo previous = getCreationalContextInstances().put(beanKey, info); +return previous == null ? null : previous.getContextualInstance(); ``` ## Evidence - **Before:** `ViewScopeCDIMapTest.testPutReturnsPreviousValue` fails with `expected: <first> but was: <...ContextualInstanceInfo@...>` **After:** passes; `impl` 1641 tests, 0 failures, 0 errors (JDK 17) ## Merge Danger **Door:** two-way **Blast Radius:** small Clean cherry-pick. Only callers using the return value of `getViewMap().put(...)` with CDI enabled are affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
