pnicolucci commented on code in PR #747:
URL: https://github.com/apache/myfaces/pull/747#discussion_r1747380767
##########
api/src/main/java/org/apache/myfaces/core/api/shared/lang/ClassUtils.java:
##########
@@ -163,14 +163,17 @@ public static Class simpleClassForName(String type)
/**
* Same as {link {@link #simpleClassForName(String)}, but will only
- * log the exception and rethrow a RunTimeException if logException is
true.
+ * log the exception and rethrow a RunTimeException if
logAndThrowException is true.
*
* @param type
- * @param logException - true to log/throw FacesException, false to avoid
logging/throwing FacesException
+ * @param logAndThrowException - true to log and throw FacesException,
false to avoid logging and throwing
+ * the FacesException
* @return the corresponding Class
- * @throws FacesException if class not found and logException is true
+ * @throws FacesException if class not found and logAndThrowException is
true
*/
- public static Class simpleClassForName(String type, boolean logException)
+ // @Override MYFACES-4449: Methods that call
ClassUtils.class.getClassLoader() need to be here
Review Comment:
Shouldn't this comment be in the IMPL ClassUtils.java not in the API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
