tandraschko commented on code in PR #730:
URL: https://github.com/apache/myfaces/pull/730#discussion_r1686490287
##########
impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java:
##########
@@ -579,6 +579,11 @@ public VisitResult visit(VisitContext context, UIComponent
target)
{
((EditableValueHolder)target).resetValue();
}
+ else if (!VisitContext.ALL_IDS.equals(context.getIdsToVisit()))
+ {
+ // Render ID didn't specifically point an EditableValueHolder.
Visit all children as well.
+
target.visitTree(VisitContext.createVisitContext(FacesContext.getCurrentInstance(),
null, context.getHints()), this);
Review Comment:
can we make the visitContext static or reuseable?
currently this would create tons of the same context object, not quite good
from performance perspective
just look at PF one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
