volosied commented on code in PR #492:
URL: https://github.com/apache/myfaces/pull/492#discussion_r1082912449
##########
impl/src/main/java/org/apache/myfaces/renderkit/RendererUtils.java:
##########
@@ -693,17 +693,25 @@ else if (allowNonArrayOrCollectionValue)
public static Object getConvertedUISelectOneValue(
FacesContext facesContext, UISelectOne output, Object
submittedValue)
{
- if (submittedValue != null && !(submittedValue instanceof String))
+
+ if(submittedValue == null)
+ {
+ if (log.isLoggable(Level.FINE))
+ {
+ log.fine("No conversion necessary for null uiselectone value:
client id " + output.getClientId());
+ }
+ return null;
Review Comment:
Might be worth a challenge? Unless we switch to enums which would signify
that no value is inputted, hence no conversion necessary (rather than rely on
this empty string / null nonsense).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
