volosied commented on PR #435: URL: https://github.com/apache/myfaces/pull/435#issuecomment-1358852030
Thanks for pointing that out. I noticed that we always write the id in the `"partial-response` tag, but Mojarra only writes it under the condition you pointed above (viewroot instanceof NamingContainer). However, this leads to a problem because Mojarra seems to be out of compliance here per the schema here: https://jakarta.ee/xml/ns/jakartaee/web-partialresponse_4_0.xsd ``` <xsd:element name=“partial-response” type=“jakartaee:partial-responseType”> <xsd:annotation> <xsd:documentation> [ <p> The “partial-response” element is the root of the partial response information hierarchy, and contains nested elements for all possible elements that can exist in the response.</p> <p>This element must have an “id” attribute whose value is the return from calling getContainerClientId() on the UIViewRoot to which this response pertains. </p> </xsd:documentation> </xsd:annotation> </xsd:element> ``` _"This element must have an “id” attribute whose value is the return from calling getContainerClientId() on the UIViewRoot to which this response pertains. "_ Mojarra should write it every time, not just in some cases. The question becomes how can view know if the viewroot is an instance of NamingContainer in the ajax responses. This is as far I've looked into it and will try to get a conversation started in our existing head id challenge. Links: MyFaces https://github.com/volosied/myfaces/blob/3984a6dfb7960f2ad6738653f2beea55f7ce154f/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java#L437 Mojarra: https://github.com/eclipse-ee4j/mojarra/blob/baf7998ef3492742d7e407c48c2fc3e87cb758c7/impl/src/main/java/com/sun/faces/context/PartialViewContextImpl.java#L437 https://issues.apache.org/jira/projects/MYFACES/issues/MYFACES-3973?filter=allissues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
