volosied commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1311973354
File uploads look good!
```
field: multipleSelection, name: test2.txt, size: 13
field: multipleSelection, name: test1.txt, size: 13
```
The f:param still isn't working for me...? However, I created a java fix
here to use object notation over Arrays for params and it works with the patch.
```
diff --git
a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java
b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java
index ec08b2a60..588ba1eb2 100644
---
a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java
+++
b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java
@@ -346,7 +346,7 @@ private StringBuilder addChildParameters(FacesContext
context, List<UIParameter>
{
//add child parameters
StringBuilder params = SharedStringBuilder.get(context,
SB_ADD_CHILD_PARAMETERS);
- params.append('[');
+ // params.append('[');
for (int i = 0, size = validParams.size(); i < size; i++)
{
@@ -398,13 +398,13 @@ else if (buff != null)
params.append(',');
}
- params.append("['");
+ params.append("{'");
params.append(name);
- params.append("','");
+ params.append("':'");
params.append(strParamValue);
- params.append("']");
+ params.append("'}");
}
- params.append(']');
+ // params.append(']');
return params;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
