[ 
https://issues.apache.org/jira/browse/MYFACES-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700615#comment-16700615
 ] 

Eduardo Breijo commented on MYFACES-4269:
-----------------------------------------

[~tandraschko] the changes look good to me. It makes sense to do the caching in 
a level above as that should improve performance even more compared to the 
original caching I did for the "isFacesServlet" method. Thanks!

> [perf] getServletRegistrations is slow and not cached
> -----------------------------------------------------
>
>                 Key: MYFACES-4269
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4269
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.3.2
>            Reporter: Thomas Andraschko
>            Priority: Major
>             Fix For: 2.3.3
>
>         Attachments: MYFACES-4269.patch
>
>
> seems like servletContext#getServletRegistrations does internal always a new 
> lookup instead of caching it (on tomcat 9.x)
>  we can simple cache the FacesServletRegistration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to