[ 
https://issues.apache.org/jira/browse/TOBAGO-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958786#comment-15958786
 ] 

Hudson commented on TOBAGO-1721:
--------------------------------

SUCCESS: Integrated in Jenkins build Tobago Trunk #849 (See 
[https://builds.apache.org/job/Tobago%20Trunk/849/])
TOBAGO-1721 Optimize HTML output when two renderer are involved
* renaming *Aternative* to *Inside* (lofwyr: 
[http://svn.apache.org/viewvc/?view=rev&rev=1790381])
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/component/RendererTypes.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/BarRenderer.java
* (delete) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonAlternativeInRenderer.java
* (add) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonInsideInRenderer.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java
* (delete) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinkAlternativeCommandRenderer.java
* (delete) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinkAlternativeLinksRenderer.java
* (add) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinkInsideCommandRenderer.java
* (add) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinkInsideLinksRenderer.java
* (delete) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinksAlternativeBarRenderer.java
* (add) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinksInsideBarRenderer.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinksRenderer.java
* (delete) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxAlternativeCommandRenderer.java
* (add) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxInsideCommandRenderer.java
* (delete) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxAlternativeCommandRenderer.java
* (add) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxInsideCommandRenderer.java
* (delete) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceAlternativeInRenderer.java
* (add) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceInsideInRenderer.java
* (delete) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneRadioAlternativeCommandRenderer.java
* (add) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneRadioInsideCommandRenderer.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/ButtonTagDeclaration.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/LinkTagDeclaration.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/LinksTagDeclaration.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectBooleanCheckboxTagDeclaration.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectManyCheckboxTagDeclaration.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectOneChoiceTagDeclaration.java
* (edit) 
tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectOneRadioTagDeclaration.java
* (edit) tobago-trunk/tobago-core/src/main/resources/scss/_tobago.scss


> Optimize HTML output when two renderer are involved
> ---------------------------------------------------
>
>                 Key: TOBAGO-1721
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1721
>             Project: MyFaces Tobago
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.3
>            Reporter: Henning Noeth
>            Assignee: Henning Noeth
>
> A renderer produce HTML code without consider the environment.
> For example:
> The InRenderer always generate a <span/> around children.
> If a button has children, the ButtonRenderer always generate a <span/> 
> element around the button and its children.
> So if a <tc:button> is inside a <tc:in>, two <span/> elements would be 
> generated.
> In this case, the renderer should work together, to only generate one <span> 
> element.
> The generated code is more compact.
> It's more the way of bootstrap.
> And because of that, there are less problems to solve with CSS.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to