[
https://issues.apache.org/jira/browse/MYFACES-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678025#comment-13678025
]
Leonardo Uribe commented on MYFACES-3716:
-----------------------------------------
I have some comments about the patch.
- InputFile was removed, because it was a duplicate of _HtmlInputFile. In this
case, it is better to preserve the current convention about file naming.
- The code related to save/restore the state must be done directly in
_HtmlInputFile. We cannot change the way UIComponentBase works, because it was
already defined by the spec. I think the way to do it is use @JSFExcluded
annotation. I need to take a look to see if it is working in core, because if
not we could need to override the template.
- It is not necessary to keep servlet 2.5 artifact, just replace it with 3.0.
I'll do that.
- I think the part that check for "multipart/form-data" could cause problems
because not all request should be "multipart/form-data", only the ones where it
is necessary to decode or extract the file. A check will look better overriding
decode() method.
> Implement h:inputFile
> ---------------------
>
> Key: MYFACES-3716
> URL: https://issues.apache.org/jira/browse/MYFACES-3716
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-344
> Reporter: Leonardo Uribe
> Attachments: inputfileperfect.patch
>
>
> Implement h:inputFile as described in the spec
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
