Hi Ok, now I get it. It is a typo error on WebConfigParamsLogger.vm. I'll fix it now.
regards, Leonardo Uribe 2012/8/27 Mike Kienenberger <[email protected]>: > It's not a matter of being harmful. It's a matter of being wrong. > The messages are switched. > I just double-checked both the source and my own app. > > INFO [main 08-27 13:39:03] WebConfigParamsLogger: Starting up > Tomahawk on the RI-JSF-Implementation. > > And I definitely don't have the RI on my classpath > :-) > > I'd fix it right now, but I don't have the latest sources/project > checked out on this machine. > > On Mon, Aug 27, 2012 at 1:47 PM, Leonardo Uribe <[email protected]> wrote: >> Hi >> >> I don't think the message causes any problem. When >> org.jboss.jbossfaces.WAR_BUNDLES_JSF_IMPL is enabled, since the ri >> jars are still in the classpath, the related code finds them (look for >> com.sun.faces.application.ApplicationImpl class). But in practice, >> myfaces jars are used. >> >> regards, >> >> Leonardo Uribe >> >> 2012/8/27 Mike Kienenberger <[email protected]>: >>> Looks like you found something that we need to fix. >>> >>> Can you open an issue please, preferrably with a unified diff patch? >>> >>> >>> On Mon, Aug 27, 2012 at 11:38 AM, Jon Bionda <[email protected]> >>> wrote: >>>> myfaces-core-2.1.8 source >>>> >>>> org.apache.myfaces.webapp.WebConfigParamsLogger.logWebContextParams() >>>> >>>> >>>> >>>> Not a big deal but it caused me a few hours of scratching my head so >>>> thought >>>> I would subscribe and post this. >>>> >>>> >>>> >>>> I am getting the "Starting up Tomahawk on the RI-JSF-Implementation." >>>> message on startup with JBoss 7.1.1 when using the >>>> org.jboss.jbossfaces.WAR_BUNDLES_JSF_IMPL context parm to stop it from >>>> loading the JSF RI. I see lots of myfaces initialization msgs in the log >>>> so >>>> I was pretty sure(hopeful) the message was wrong so I downloaded and looked >>>> at the code and think I see a reverse logic error in the source file >>>> identified at the top of this email. >>>> >>>> >>>> >>>> Here’s the code and I think the wrong message is being issued for when it >>>> checks for availability of both the RI and myfaces classes. >>>> >>>> >>>> >>>> if (myfacesConfig.isTomahawkAvailable()) >>>> >>>> { >>>> >>>> if(myfacesConfig.isMyfacesImplAvailable()) >>>> >>>> { >>>> >>>> if(log.isLoggable(Level.INFO)) >>>> >>>> { >>>> >>>> log.info("Starting up Tomahawk on the >>>> RI-JSF-Implementation."); ßmsg should be MyFaces >>>> >>>> } >>>> >>>> } >>>> >>>> >>>> >>>> if(myfacesConfig.isRiImplAvailable()) >>>> >>>> { >>>> >>>> if(log.isLoggable(Level.INFO)) >>>> >>>> { >>>> >>>> log.info("Starting up Tomahawk on the >>>> MyFaces-JSF-Implementation"); ß msg should be RI >>>> >>>> } >>>> >>>> } >>>> >>>> } >>>> >>>> >>>> >>>>
